[fix][8684] Typo in Lightning Overload

[reeshack]

What bug does the patch fix? What features does the patch add?

It fixes a typo that caused that shaman Lightning Overload talent was not procing at last two ranks (7th and 8th) of Chain Lightning.

For which repository revision was the patch created?

Rev. 8632

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

Haven't found any to this specific issue.

Who has been writing this patch? Please include either forum user names or email addresses.

Me, reeshack

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 0fbb085..fc38412 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -6241,8 +6296,8 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu
                    case 10605: spellId = 45300; break;     // Rank  4
                    case 25439: spellId = 45301; break;     // Rank  5
                    case 25442: spellId = 45302; break;     // Rank  6
-                    case 49268: spellId = 49270; break;     // Rank  7
-                    case 49269: spellId = 49271; break;     // Rank  8
+                    case 49270: spellId = 49268; break;     // Rank  7
+                    case 49271: spellId = 49269; break;     // Rank  8
                    default:
                        sLog.outError("Unit::HandleDummyAuraProc: non handled spell id: %u (LO)", procSpell->Id);
                        return false;

I haven't tested it but I think it is quite obvious

EDIT: OK, I've just tested it and it works correctly for me now

[Wojta]

How is that possible? Id changed(client version switch etc.) or just dev mistake?

[reeshack]

I would say somebody just misread and switched those two (probably while updating to client version 3.0.3) as they are differently sorted than the previous - the triggered spell ID is lower than the ID of the trigger which was not the other ranks of this spell.

[KAPATEJIb]

http://github.com/insider42/mangos/commit/699418e9a742010f586a38e0044a68103df5da80 , but anyway author of that patch isn't me, i forgot who created it

[reeshack]

Well I searched only on the forum and haven't found anything, but if you remember the name I will add it of course

Anyway the main thing is that it confirmes that the correction is right

[VladimirMangos]

In [8684]. Thank you!

[darkstalker]

nice, really never noticed that overload wasnt proc'ing from chain before.