[patch in svn][4588] Giving Db A Priority For Items' Proc Chance Settings

[Guest]

Discussion in Bug reports - http://getmangos.eu/community/viewtopic.php?id=1468.

In current dbc spell proc chance for spell 36111 (linked to item 30090) is not 101 anymore, it's 100% exactly. I prepared a patch to change core to make DB proc data override any dbc settings - imho that shouldn't be a problem for core.

Index: src/game/Player.cpp
===================================================================
--- src/game/Player.cpp        (revision 4587)
+++ src/game/Player.cpp        (working copy)
@@ -6141,16 +6141,15 @@

                float chance = spellInfo->procChance;

-                if(chance > 100)
+                if(spellData.SpellPPMRate)
                {
-                        if(spellData.SpellPPMRate)
-                        {
-                                uint32 WeaponSpeed = GetAttackTime(attType);
-                                chance = GetPPMProcChance(WeaponSpeed, spellData.SpellPPMRate);
-                        }
-                        else
-                                chance = GetWeaponProcChance();
+                        uint32 WeaponSpeed = GetAttackTime(attType);
+                        chance = GetPPMProcChance(WeaponSpeed, spellData.SpellPPMRate);
                }
+                else if(chance > 100)
+                {
+                        chance = GetWeaponProcChance();
+                }

                if (roll_chance_f(chance))
                        this->CastSpell(Target, spellInfo->Id, true, item);

Tested the item with ppmRate of 3 and 9 - chances look good.

Any comment would be appreciated.

[VladimirMangos]

Patch incorrect: spell casted at item "chance to hit" and ppmRate must be set in item_template.spellppmRate_N and this is DB problem. Patch rejected.

[added]Ok, I too fast as often

[added2]In [4588] Thank you

[CHili]

W parameters of spellppmRate can be?