[fix] Interrupt effects duration reduction (by aura 234)

[reeshack]

What bug does the patch fix? What features does the patch add?

It fixes talents such as Focused Mind or Improved Concentration Aura to work also with interrupt effects.

For which repository revision was the patch created?

Rev. 8754

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

Haven't found any.

Who has been writing this patch? Please include either forum user names or email addresses.

Me, reeshack.

Paste2.org: http://paste2.org/p/502737

[darkstalker]

this doesnt look right, a typo maybe? you're not using the 'iter' inside the for

+                for(Unit::AuraList::const_iterator iter = mMechDurModNotStackAuras.begin(); iter != mMechDurModNotStackAuras.end(); ++iter)
+                {
+                    duration = unitTarget->CalculateSpellDuration(m_spellInfo, i, unitTarget);
+                }

[reeshack]

No it is not a typo, it is the spell effect index not the other "iter". Anyway thank you for response.

[darkstalker]

ye but remove the for loop if you not using the "iter", its useless then

[reeshack]

Not in my opinion, "CalculateSpellDuration" is also used for two another auras (#232,#246), the duration needs to be reduced only in aura #234 case.

[darkstalker]

ye, but the iteration variable is "iter", and you not using it in any way inside the loop

[reeshack]

Oh I see what you mean...then:

+                if (!mMechDurModNotStackAuras.empty())
+                {
+                    duration = unitTarget->CalculateSpellDuration(m_spellInfo, i, unitTarget);
+                }

diff updated...

EDIT: I've just realized that this part is also undeeded as "CalculateSpellDuration" differenciates between those auras by mechanic...so I removed this whole...updated