[fix][9040] Furor (Cat Form)

[Auntie Mangos]

I will test, i expect described work and do some tests ( ) bit not catch this problem.

It's not visible at first time. Shifting in and out cat form doesn't show the issue as long as you didn't use your energy.

Burn your cat energy, to be nearly depleted (around 0 ). Shift out, shift back in cat form : with the 9040 change, you get back to furor max energy allowed, while you should have been to 0+some energy gain relative to the time spend after the last cast attack, whatever the form you are.

The logic for this patch was correct (linky)

[laise]

What bug does the patch fix? What features does the patch add?

- fixes Furor energy restoring

For which repository revision was the patch created?

- 8852

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

- haven't seen any

Who has been writing this patch? Please include either forum user names or email addresses.

- me

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index c30657b..caee220 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -2997,8 +2997,8 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
                    if (m_modifier.m_miscvalue == FORM_CAT)
                    {
                        m_target->SetPower(POWER_ENERGY, 0);
-                        if(urand(1,100) <= FurorChance)
-                            m_target->CastSpell(m_target, 17099, true, NULL, this);
+                        int32 basepoints = FurorChance;
+                        // Furor chance is now amount of energy for cat form
+                        m_target->CastCustomSpell(m_target, 17099, &basepoints, NULL, NULL, this); 
                    }
                    else
                    {

but I'm not sure what they meant with "keeps by up to X energy when shapeshifting"

[Sarjuuk]

Energy should regenerate independent from the current form you're in (much like Mana).

With each rank of this talent you're allowed to keep 20*rank of it.

This was changed to prohibit Powershifting. Now you'd end up with roughly the same energy after a powershift, even with maxed Furor.

What you patch does, is to give 20*rank energy to the user after each shift, independent of what he had, when leaving Cat. So.. noooo, not a good way

This is an old fix of mine. Maybe it gives an idea how it should work (even if its done in an unacceptable way^^)

http://spezies0815.datearea.de/index.php?s=diff&n=Furor.diff

[MrLama]

Bump and here is alsou my patch

revision 9037

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index 77ade4c..5b2ac72 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -3008,7 +3008,7 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
                case FORM_DIREBEAR:
                {
                    // get furor proc chance
-                    uint32 FurorChance = 0;
+                    int32 FurorChance = 0;
                    Unit::AuraList const& mDummy = m_target->GetAurasByType(SPELL_AURA_DUMMY);
                    for(Unit::AuraList::const_iterator i = mDummy.begin(); i != mDummy.end(); ++i)
                    {
@@ -3023,7 +3023,7 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
                    {
                        m_target->SetPower(POWER_ENERGY, 0);
                        if(urand(1,100) <= FurorChance)
-                            m_target->CastSpell(m_target, 17099, true, NULL, this);
+                            m_target->CastCustomSpell(m_target, 17099, &FurorChance, NULL, NULL, true, NULL, this);
                    }
                    else
                    {

[VladimirMangos]

In [9040], i add brak at 0 chance for avoid always restore enegry as pointed by Sarjuuk

[Sarjuuk]

aaarg..!

thats not what i meant

This Talent got intentionally changed, to prevent Powershifting:

For example, you depleted your energy and instead of waiting for it to regenerate, you could shift out and in Cat Form again, to have a chance of (20*rank)% to set your energy to 40. Simple trading of Mana for Energy.

How it works now (r9040):

You powershift and have a chance of 100% to set your energy to 20*rank. (effectively 100)

So, it just got worse...

How it should work:

Think of it, like Mana. You cant see it, but its still there and regenerating after the usual rules (5sec-Spirit-regen. ect)

Lets asume, you have 3/5 points in this talent ("[..]you keep up to 60 Energy[..]") and shift out of Cat Form to cast a spell with 2sec casttime, to shift into Cat Form immediately after.

with 60 Energy out:

- regenerates 20 Energy while casting

- now 80 Energy > 60 allowed by Talent => Energy is set to 60

with 40 Energy out:

- still 20 energy silently regenerated while casting the spell.

- now 60 Energy = 60 allowed by Talent => Final outcome is 60

with 20 Energy out:

- regenerates 20 Energy while out of Form

- now 40 Energy < 60 Allowed by Talent => Energy is left at 40

I hope, that made it clearer

[VladimirMangos]

I will test, i expect described work and do some tests ( ) bit not catch this problem.

[goldberg002]

aaarg..!

thats not what i meant

This Talent got intentionally changed, to prevent Powershifting:

For example, you depleted your energy and instead of waiting for it to regenerate, you could shift out and in Cat Form again, to have a chance of (20*rank)% to set your energy to 40. Simple trading of Mana for Energy.

How it works now (r9040):

You powershift and have a chance of 100% to set your energy to 20*rank. (effectively 100)

So, it just got worse...

How it should work:

Think of it, like Mana. You cant see it, but its still there and regenerating after the usual rules (5sec-Spirit-regen. ect)

Lets asume, you have 3/5 points in this talent ("[..]you keep up to 60 Energy[..]") and shift out of Cat Form to cast a spell with 2sec casttime, to shift into Cat Form immediately after.

with 60 Energy out:

- regenerates 20 Energy while casting

- now 80 Energy > 60 allowed by Talent => Energy is set to 60

with 40 Energy out:

- still 20 energy silently regenerated while casting the spell.

- now 60 Energy = 60 allowed by Talent => Final outcome is 60

with 20 Energy out:

- regenerates 20 Energy while out of Form

- now 40 Energy < 60 Allowed by Talent => Energy is left at 40

I hope, that made it clearer

Yes, I can confirm.

[VladimirMangos]

Must be fixed now in [9049]