laise

Maybe just need to rename bgData to EntryPoint, instance id can hold LFG instance id and team can be used for dungeons such as Halls of Reflection

1)if dungeon is finished - haven't seen any pop up 2)rolecheck is always run when lfg group joins queue(doesn't matter if leader or group member initiated it) not sure but I think if you remain in the group and all encounters are complete you can't teleport back there. about re-queue - are you sure that only party leader can run it?

First you need an object that updates based on how much time passed like unit/aura/etc. and parameter to hold current position in list on it, then it's same as SD2 timers for events - just move to next element when timer expired

works fine on latest rev. Any example spell that doesn't get it's damage reduced?

1) works fine on latest rev 2) shouldn't affect critical chance

happens because actual aura is applied on target and damage, being redirected, hits caster, which doesn't have any related auras so can't proc. Need to call proc on target for redirected by this aura's spell, also need to confirm if this aura forces any type of procs happen on target when caster is hit or just this specific aura.

Ok, will check yours, but after LFG related stuff is finished I very rarely check other forums' patches

because yours is later than this one, don't provide clean src compatible version and if it's based on this one - why you don't provide any links here ?

in [11778]. Thanks =)

Maybe need to have different section for custom stuff, but I don't see anything wrong with having it here - I mean doing something on your own is still learning and blizzlike or not is important only for patches meant for main branch. Ofc bug reports for custom cores won't be accepted. 1) MaxPlayerLevel in mangosd.conf, but need to check if it won't cause variable overflow since all damage & stat values will become really big 2) in general - in CalculateSpellDamage, can have something like custom multiplier and if really want can add it's value to config, so you won't have to compile it everytime you change that value

you mean https://github.com/mangos/mangos/commit/f683e3cb007a678cb537b3d3d09d29ab32321e99 is being wrong? SetStackAmount method reapplies modifiers (first apply anyway is called after holder creation) and sends update to client (adding holder will send that update anyway and it shouldn't be twice)

I meant if there is any info that LFR has something in common with dungeon finder in how it should be implemented or it can be something entirely different that just happens to share some packet/s with LFD

soo lezz revive it. There are few things I don't quite understand in all dungeon finder implementations: - why there are different queues for players and groups ? - why looking for raid feature tends to be mixed with dungeon finder - I mean if they should be entirely different things or LFR just displays "hidden" in LFD info in different way (i.e. players/groups queued for specific instance) discuss

Yeah but is there any source of information to confirm that this is how it used to worked on retail? (because 3.3.5 and later should work this way)

what spell is bugged and why healing-done should be updated on tick?

if it should drop charges when target is actually harmed then why do it on target selection ? both Grounding and Intervene have proc flags for on-hit case and also according to wowwiki & wowhead it is possible to redirect more than one spell same time if second spell is cast before first hits. about wrong redirects - seems like it should ignore all SPELL_SCHOOL_MASK_NORMAL(can add check in SelectMagnetTarget or before or maybe drop SPELL_DAMAGE_CLASS_NONE from condition) and AoEs --- changed to proc using way in [11766]

not confirmed in 11761, cast end procs still being worked on, so better update

Should be fixed in [11760]

can you tell spell id of pet charge?

Yeah , it happened after spell mod change. main problem is that there is no difference between spells that proc on cast end and spells that proc on actual hit, for example 63280 that should be on end of cast and 55440 that needs actual hit. Maybe need to have special proc_ex for such cases but it will require adding lots of records into spell_proc_event.

ProcDamageAndSpellFor related crashes should be fixed in [11757]

should be fixed in [11752]

should be fixed in [11738]. Please confirm if armor increasing enchantments are still bugged

should be fixed in [11733]

should be fixed in [11717]