laise

updated for 10075

no, stacking itself of different spells should work as it was before

alternative patch already in master

in [10049]. Thanks =)

Eye of acherus is not even implemented.. so pointless to report it in relation to this patch

DiamonCore? never heard about that..

updated for 10030

not happening on clean core

first post updated : increased aura slot limit til 255, possibly 64 was added before passive auras were started to be sent

in [10022]. Thanks =)

no, spell holder is also per target - but holder is 1 for 1 spell from same caster - instead of having x auras each one on its own, ofc there are still auras existing but adding/removing spell on target is based on holder and not on single auras - for example in stacking case the check is run only once for whole holder, before applying aura modifiers, unlike it was done before for each aura

In general - focuses around creating and using shared object(SpellAuraHolder) between auras to keep some data that now is duplicate for auras of same spell like target, caster, charges etc. * aura map on Unit will now keep SpellAuraHolders - in some cases can be faster to search on it * stacking of different spells is a bit modified to support this change but should work as it was before * instead of saving auras saves the whole holder - had to delete old data from character_aura, pet_aura (see sql) - also I disabled saving for not own area auras * added 2 remove modes - AURA_REMOVE_BY_EXPIRE, AURA_REMOVE_BY_SHIELD_BREAK (needed for HandleSpellSpecificBoosts which is now called from holder) * as a side effect client related parts of Warbringer/Juggernaut and others were fixed due to changes to IsNeedVisibleSlot Please report any bugs/crashes =) code: 10104 http://paste2.org/p/893418 10075 http://paste2.org/p/882830 10048 http://paste2.org/p/870738 10030 http://paste2.org/p/865338 10023 http://paste2.org/p/862196 10011 http://paste2.org/p/859456 sql for all revisions: http://paste2.org/p/859458 another sql for specific revisions: http://paste2.org/p/870734 - outdated sql(before 10075) http://paste2.org/p/882837 - 10075

maybe u need to add values to spell_script_target for all firework spells with entry of launcher GO?

first post updated

@ coldhunter, Bartuc3, Raynar please, can you all talk in english or use pms?

Drain Soul - don't remember seeing it crit on retail

in fact slot is not given based on single aura..and not only 262 needs to get aura slot - several other passive spells too. if any1 wants to test : bool Aura::IsNeedVisibleSlot(Unit const* caster) const { bool totemAura = caster && caster->GetTypeId() == TYPEID_UNIT && ((Creature*)caster)->isTotem(); if (m_spellProto->Attributes & (SPELL_ATTR_UNK7 | SPELL_ATTR_EX_UNK28)) return true; else if (m_spellProto->procFlags) return true; else if (IsSpellHaveAura(m_spellProto, SPELL_AURA_PROC_TRIGGER_SPELL) || IsSpellHaveAura(m_spellProto, SPELL_AURA_PROC_TRIGGER_SPELL_WITH_VALUE) || IsSpellHaveAura(m_spellProto, SPELL_AURA_PROC_TRIGGER_DAMAGE)) return true; // frost fever , TODO : find generic way else if (m_spellProto->Id == 59921) return true; // passive auras (except totem auras) do not get placed in the slots return !m_isPassive || totemAura; }

in [9900]. Thanks =)

yea but in default calculation (not spell bonus data related part), u haven't added LvlPenalty to coeff unlike it is where coeff taken from db.. so I wanted to know if LvlPenalty should be part of coeff or not - cause it shouldn't be different for db spell bonus and default cases

strange: when using spell bonus data LvlPenalty is part of coeff but in default calculation its not..

15% is not total instant damage , its the base damage , something like basepoints for a regular spell. Currently it benefits from all damage increasing bonuses like any regular spell, but instant spell also gets some bonus damage from spell power due to lack of record in spell_bonus_data. idk if this should happen or not and it might be the source of high damage problem, however i haven't found any retail data regarding instant damage and not over time one

client seems to crash if any of these sent : EQUIP_ERR_ITEM_MAX_LIMIT_CATEGORY_COUNT_EXCEEDED_IS EQUIP_ERR_ITEM_MAX_LIMIT_CATEGORY_SOCKETED_EXCEEDED_IS EQUIP_ERR_ITEM_MAX_LIMIT_CATEGORY_EQUIPPED_EXCEEDED_IS

instant can have its own spell power bonus.. need to confirm if it is 0% or whatever..

wowwiki doesn't have info on Improved Devouring Plague(talent) coeff..any info about damage of periodic and instant from retail present?

why should it change if you already cast a spell? I mean its on target, why any caster side changes should affect it? Periodic doesn't mean re-evaluate all bonuses on each damage dealing.. at least according to my info current way is how it should be