[fix]Berserk

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

fixes Berserk part that allows Mangle (Bear) to hit additional targets

For which repository revision was the patch created?

should work on latest

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=10816

Who has been writing this patch? Please include either forum user names or email addresses.

me

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index 4be1945..e8fef7c 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -2542,6 +2542,13 @@ void Spell::cast(bool skipCheck)
                AddPrecastSpell(57723);                     // Exhaustion
            break;
        }
+        case SPELLFAMILY_DRUID:
+        {
+            // Berserk (Bear Mangle part)
+            if (m_spellInfo->Id == 50334)
+                AddTriggeredSpell(58923); 
+            break;
+        }
        default:
            break;
    }

[przemratajczak]

updated verion to 9365 http://www.sendspace.com/file/cn8za2 also included check for bear/direbera form

[kisslota]

good work. The talent perfectly works

[wow-masters]

Bump,

Tested works fine

[Betaman2k]

testet not working compile error

../../../src/game/Spell.cpp: In member function âvoid Spell::cast(bool)â:

../../../src/game/Spell.cpp:2682: error: duplicate case value

../../../src/game/Spell.cpp:2641: error: previously used here

../../../src/game/Spell.cpp:2689: error: expected primary-expression before âelseâ

../../../src/game/Spell.cpp:2689: error: expected `;' before âelseâ

make[3]: *** [spell.o] Error 1

[przemratajczak]

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index c8b68a7..4c0df6e 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -2854,6 +2854,9 @@ void Spell::cast(bool skipCheck)
            // Faerie Fire (Feral)
            if (m_spellInfo->Id == 16857 && m_caster->m_form != FORM_CAT)
                AddTriggeredSpell(60089);
+            // Berserk (Bear/Direbear Mangle affecting up to 3 targets)
+            else if (m_spellInfo->Id == 50334)
+                AddTriggeredSpell(58923);
            break;
        }
        case SPELLFAMILY_ROGUE:

ps is it only me seeing code box with only one line in forst post?

[alexluana]

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp

index 4be1945..e8fef7c 100644

--- a/src/game/Spell.cpp

+++ b/src/game/Spell.cpp

@@ -2542,6 +2542,13 @@ void Spell::cast(bool skipCheck)

AddPrecastSpell(57723); // Exhaustion

break;

}

+ case SPELLFAMILY_DRUID:

+ {

+ // Berserk (Bear Mangle part)

+ if (m_spellInfo->Id == 50334)

+ AddTriggeredSpell(58923);

+ break;

+ }

default:

break;

}

I can see this

with respect,

Axel

[kich0]

ps is it only me seeing code box with only one line in forst post?

better now ) ?

[texen]

The part where says "Clears the effect of Fear and makes you immune to Fear for the duration" is bug in 3.3.5.

Maybe the fix can be included to the patch.

[reeshack]

Also, there is another bug with this spell (and probably generally with all spells using SPELLMOD_COST) - the -50% cost pct modifier is applied after flat modifiers.

Let me explain it on an example - Mangle (Cat) 's base cost is 40 energy, using Improved Mangle talent it is 34 energy so under the effect of Berserk it should be (the tooltip also says that) 17 energy. But in current state it seems to me, that the -50% mod is applied to the base value (40) and the flat ones are applied after that, causing Mangle (Cat) cost only 14 energy (40 * 0.50 - 6).

Actually, I'm not sure how this priority issue should be handled - are pct mods supposed to be calculated first? Or should be first the modifier, whose aura has been firstly applied?