[9100] [Fix] Max targets limitation for an Hyjal spell (31347)

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

Fixed spell "Doom".

For which repository revision was the patch created?

9086

Is there a thread in the bug report section or at lighthouse?

http://getmangos.eu/community/viewtopic.php?id=1739

http://getmangos.eu/community/viewtopic.php?id=2899

Who has been writing this patch? Please include either forum user names or email addresses.

Me

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index 8cac57a..1339b90 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -1313,6 +1313,7 @@ void Spell::SetTargetMap(uint32 effIndex, uint32 targetMode, UnitList& targetUni
        {
            switch(m_spellInfo->Id)
            {
+                case 31347:                                 // Doom
                case 33711:                                 // Murmur's Touch
                case 38794:                                 // Murmur's Touch (h)
                    unMaxTargets = 1;

[NoFantasy]

This will not exclude the top aggro target, as it should. I'm a bit noob with the spell system though, will it still be proper to limit spell here and the exclusion of top aggro target must be done another place in code?

[xeross155]

Isn't there a targetMode (I'm not entirely sure if it does what I think it does) that excludes the Top Aggro guy ?

[The_Game_Master]

The spell should only target one unit. So the target limitation is correct.

The top aggro it's part of the event, and should be added in another place.

Don't ask me where though.

[NoFantasy]

Yes, i would agree, it is still correct to limit to 1 target. Exclusion of explicit target must be done another place.