unused spell_dbc unk_320_4 field

[przemratajczak]

Hi i want to share my one findiding which could greatly simplify code used for spell_bonus_data

look at DBC field unk_320_4[1]. It is opend forum so i probably cannot post whole column but as far as i checked there could be stored direct spell_bonus_data, at least for some spells.

for example penance:

mysql> select id,spellname_1,unk_320_4_1 from dbc_spell where spellname_1 like '
%penance%';
+-------+--------------------------+-------------+
| id    | spellname_1              | unk_320_4_1 |
+-------+--------------------------+-------------+
| 47540 | Penance                  |           0 |
| 47666 | Penance                  |       0.229 |
| 47750 | Penance                  |       0.537 |
| 47757 | Penance                  |           0 |
| 47758 | Penance                  |           0 |
| 52922 | The Inquisitor's Penance |           0 |
| 52923 | The Inquisitor's Penance |           0 |
| 52983 | Penance                  |       0.537 |
| 52984 | Penance                  |       0.537 |
| 52985 | Penance                  |       0.537 |
| 52986 | Penance                  |           0 |
| 52987 | Penance                  |           0 |
| 52988 | Penance                  |           0 |
| 52998 | Penance                  |       0.229 |
| 52999 | Penance                  |       0.229 |
| 53000 | Penance                  |       0.229 |
| 53001 | Penance                  |           0 |
| 53002 | Penance                  |           0 |
| 53003 | Penance                  |           0 |
| 53005 | Penance                  |           0 |
| 53006 | Penance                  |           0 |
| 53007 | Penance                  |           0 |
| 54518 | Penance                  |           0 |
| 54520 | Penance                  |           0 |
| 63235 | Glyph of Penance         |           0 |
| 63874 | Glyph of Penance         |           0 |
| 64282 | Glyph of Penance         |           0 |
| 66097 | Penance                  |           0 |
| 66098 | Penance                  |           0 |
| 68029 | Penance                  |           0 |
| 68030 | Penance                  |           0 |
| 68031 | Penance                  |           0 |
| 69905 | Penance                  |           0 |
| 69906 | Penance                  |           0 |
| 71137 | Penance                  |           0 |
| 71138 | Penance                  |           0 |
| 71139 | Penance                  |           0 |
+-------+--------------------------+-------------+
37 rows in set (0.23 sec)

those with zeros are spell triggers used for propper spell mechanic. 0.229- dmg effect coeff - correct | 0.537 - healing coeff - correct

http://github.com/mangos/mangos/commit/20385738b8622d337a42b3d87b57fab9b75ddd1d

all those should have zeros

mysql> select id,spellname_1,unk_320_4_1 from dbc_spell where id in (31024,17712
,5707,38395);
+-------+------------------------+-------------+
| id    | spellname_1            | unk_320_4_1 |
+-------+------------------------+-------------+
|  5707 | Lifestone Regeneration |           0 |
| 17712 | Lifestone Healing      |           0 |
| 31024 | Living Ruby Pendant    |           0 |
| 38395 | Siphon Essence         |           0 |
+-------+------------------------+-------------+
4 rows in set (0.01 sec)

checked also Cone of Cold and Blizzard and few other spells that was also matching

[darkstalker]

maybe the dot and ap coeff are there as well