[fix] Shield Slam additional damage cap

[Auntie Mangos]

PATCH: http://pastebin.com/pzPnMtJ4

- What bug does the patch fix? What features does the patch add?

- it adds two caps for additional dmg provided by player's shield block value. basic cap: 34.5 * players_level, extended cap is after using Shield Block, which doubles the BV and the cap.

- For which repository revision was the patch created?

- 9763

- Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

- http://getmangos.eu/community/showthread.php?13853-Shield-Slam

- Who has been writing this patch? Please include either forum user names or email addresses.

- only me

It's my first patch so dont be harsh on me, pls ;p i dont even know if i've posted in the right place... :rolleyes:

EDIT: small correction in code, it should be fine now.

[VladimirMangos]

i think (1) block value update by self to 200%. So not need double in calclation.

(2) abs at patch notes block value cap is 30*level, 34.5 is cap for final damage...

[michalpolko]

Ad.1 double calculation is when warrior uses Shield Block, which doubles the cap, thats why i add doubled cap to the output damage.

If you dont use Shield Block - the cap is 34.5*level

If you use Shield Block - the cap is 69*level

So in other words, there are 2 caps, which depend on Shield Block skill.

Ad.2 30*level is the value where Diminishing Returns start to occur, every next SSlam would hit for lower dmg. This patch fixes Hard Cap for additional dmg from Block Value. Maybe I will also check the diminishing returns and the formula for counting BV from bonuses/talents (which is absolutely wrong right now), but right now its only the cap patch.

Helpful links:

http://forums.worldofwarcraft.com/thread.html?topicId=19110027997&sid=1

http://www.tankspot.com/showthread.php?45247-shield-slam-damage-formula

EDIT: I did some tests and it looks like Block Value is counted properly, sorry for that accusation Testers say that Shield Slam dmg is far too high, so I am trying to find the issue, but now it looks like the cap is the only one... Maybe % bonuses to the output dmg are wrong?

EDIT2: (I found out that Shield Mastery and Shield Block should both modify the base SBV only, but now Shield Block multiplies SBV already modified by Shield MAstery and this is the issue.)

[Shad00w]

Yes, Shield Slam do too much damage now, sometimes can crit above 20k HP.

[michalpolko]

here You can read about the cap, it was also confirmed by WoW players a few days ago.

[Ceris]

paladins shield of righteousness should be affected by block value cap too

http://www.wowhead.com/spell=61411

[michalpolko]

so we could fix ShoR in the same way

if this will be accepted then i'll write it for ShoR