[patch][6537] Lifetap Bug

[rj686]

* What bug does the patch fix? What features does the patch add?

Correctly implements Lifetap. The current implementation treats lifetap as shadow damage which it is not, and it shouldn't appear in the combat log.

* For which SubVersion revision was the patch created?

6529

* Is there a thread in the bug report section? If yes, please add a link to the thread.

Not that I know of.....

* Who has been writing this patch? Please include either forum user names or email addresses.

Deafboy

Index: src/game/SpellEffects.cpp
===================================================================
--- src/game/SpellEffects.cpp        (revision 6529)
+++ src/game/SpellEffects.cpp        (working copy)
@@ -1082,12 +1082,13 @@

                                if(int32(m_caster->GetHealth()) > dmg)
                                {
-                                        m_caster->SendSpellNonMeleeDamageLog(m_caster, m_spellInfo->Id, dmg, GetSpellSchoolMask(m_spellInfo), 0, 0, false, 0, false);
-                                        m_caster->DealDamage(m_caster,dmg,NULL,DIRECT_DAMAGE,GetSpellSchoolMask(m_spellInfo),m_spellInfo,false);
+                                        
+                                        // Shouldn't Appear in Combat Log
+                                        m_caster->ModifyHealth(-(int32)dmg);
+                                        
+                                        int32 mana = dmg;

-                                        int32 mana = dmg;
-
-                                        Unit::AuraList const& auraDummy = m_caster->GetAurasByType(SPELL_AURA_DUMMY);
+                                        Unit::AuraList const& auraDummy = m_caster->GetAurasByType(SPELL_AURA_DUMMY);
                                        for(Unit::AuraList::const_iterator itr = auraDummy.begin(); itr != auraDummy.end(); ++itr)
                                        {
                                                // only Imp. Life Tap have this in combination with dummy aura

[VladimirMangos]

Patch in [6537]. Thank you