[fix][6625] Periodic Leech

[thenecromancer]

SendHealSpellLog should send gain instead of new_damage * multiplier, otherwise it shows misleading numbers.

Index: game/SpellAuras.cpp
===================================================================
--- game/SpellAuras.cpp        (revision 6623)
+++ game/SpellAuras.cpp        (working copy)
@@ -5735,10 +5735,10 @@

                        int32 gain = pCaster->SpellHealingBonus(spellProto, uint32(new_damage * multiplier), DOT, pCaster);

-                        gain = pCaster->ModifyHealth(gain);
-                        pCaster->getHostilRefManager().threatAssist(pCaster, float(gain) * 0.5f, spellProto);
+                        float realGain = float(pCaster->ModifyHealth(gain));
+                        pCaster->getHostilRefManager().threatAssist(pCaster, realGain * 0.5f, spellProto);

-                        pCaster->SendHealSpellLog(pCaster, spellProto->Id, uint32(new_damage * multiplier));
+                        pCaster->SendHealSpellLog(pCaster, spellProto->Id, uint32(gain));
                        break;
                }
                case SPELL_AURA_PERIODIC_HEAL:

[VladimirMangos]

Are you sure? See other aura tick cases. Its always send full health/power amount (instead really gained) to heal/energize but real amount for lost.

I think this is correct way as i read somewhere...

[thenecromancer]

Well, you are right.

But the problem is that it does not send value modified by % healing recieved auras ( eg. Mortal Strike ).

This must send value changed by spellhealingbonus() anyway thanks you for your suggestion it must be a little different

EDIT: updated first post with code correctly sending overheal

[VladimirMangos]

In [6625] with small variable names cleanup. Thank you