[Bug] Archimonde Soul-Charge Spells

[Schmoozerd]

Hi guys,

unfortunately, I am unable to solve this problem myself, so I hope for your help

Mangos Version: ~10050 (was broken quite some time earlier)

Custom Patches: none

SD2 Version: 1715

Database Name and Version : UDB 391

How it SHOULD work: using a soul charge should consume (at most!) one charge

How it DOES work: depending on the colors, see below(1) - some unleash spells consumes too much

This is a forward bug-report from SD2-forum, http://www.scriptdev2.com/project.php?issueid=962 started by Forusim, and clearly(2) a mangos bug.

Related spells:

http://www.wowhead.com/spell=32052 (red aura) used by http://www.wowhead.com/spell=32053

http://www.wowhead.com/spell=32045 (yellow) used by http://www.wowhead.com/spell=32054

http://www.wowhead.com/spell=32051 (green) used by http://www.wowhead.com/spell=32057

(1) What is happening:

if archi uses red (32053) this spell consumes _all_ soul charges (also yellow and green)

if archi uses yellow (32054) this spell consumes the whole yellow stack (instead of only one charge)

if archi uses green (32057) this spell consumes no charge at all

What should happen: I think all three spells should have the same behaviour, and this should be:

* Consume exactly one charge (of the right color)

* or consume no charge at all (then the consuming would have to be scripted)

(2) simple script to test, and also proof that this is clearly a mangos-related problem

http://paste2.org/p/851381 (just copy&paste over the (test-servers) archimonde file in the SD2 directory

[Forusim]

Although NoFantasy fixed this issue in http://github.com/mangos/mangos/commit/23cdcdeda429ad4cba9d62cdd111df85795929d7

there is still one problem remaining. Archimondes abilities(http://www.wowhead.com/npc=17968#abilities) will remove the soulcharges and there will be no unleash.

Maybe blizz want to unleash the charges with other spells and have hardcoded this in the spell.dbc?

Anyhow (m_removeMode == AURA_REMOVE_BY_EXPIRE) will not work right here. I think it needs more research.

As hotfix i just reduced the expiring time to SetAuraDuration(rand()%2*IN_MILLISECONDS);

[Schmoozerd]

can you explain, which abilities will remove anything at all?

[Forusim]

http://www.wowhead.com/spell=32014

http://www.wowhead.com/spell=31970

http://www.wowhead.com/spell=31972

Just go the boss and cast the soulcharges on him, and see what he will do. Everytime he cast one of his abilities the charges will be removed.

Sometimes if the charges expire fast, then he will cast the unleash.