[Mangos-0.12] enchantments bug

[mns]

After [non-trade slot item enchanting at trade complete] some items enchantments can be used in trade .

but in fact they should not be used in trade.

Edit : This part is old Bug (some items enchantments can be used in trade .but in fact they should not be used in trade)

New Bug is enchantmets spell in trade not effect and decrease enchantment items .

for example :

http://www.wowhead.com/item=29535

http://www.wowhead.com/item=24276

this cause item enchantment not decrease and player can use that item again and again .

Another one :

when used some enchantments in items must be decrease charges but now it doesn't do so .

for example :

http://www.wowhead.com/item=22522

[mns]

Bug still in [6f44fd6b7913d3834eae75ebbba35f833107830c]

[mns]

This code in TradeHandler.cpp add enchantment to traded Item after accept trade but not effecting and decrease item enchantment charges or stack .

possible missed spell information setting.

           his_spell = new Spell(trader, spellEntry, true);
           his_spell->m_CastItem = castItem;
           his_targets.setTradeItemTarget(trader);
           his_spell->m_targets = his_targets;
           .
           .
           .
           .
       if (his_spell)
           his_spell->prepare(&his_targets);

Emergency fix (not offilike):

Deleting this code in spell.cpp

       // if trade not complete then remember it in trade data
       if (!my_trade->IsInAcceptProcess())
       {
           // Spell will be casted at completing the trade. Silently ignore at this place
           my_trade->SetSpell(m_spellInfo->Id, m_CastItem);
           return SPELL_FAILED_DONT_REPORT;
       }

this cause enchant accept without problem before accepting trade .