[fix] map liquid extraction bug

[Auntie Mangos]

Still not correct, but as Lynx said the liquid fix is low impact.

The terrain hole data is probably a bigger deal, but I never wrote code for the core to use it.

Of course, both fixes are included in this thread

[faramir118]

The extractor omits a row and column of liquid height data:

http://github.com/faramir118/mangos/commit/883c660697483c0edb874cc35382b71eaae78f55

Not a huge bug, but it was a problem for my movemap project.

[Lynx3d]

Hm i'm not sure this is really correct.

currently, core assumes flat water and only uses the lower left vertex of a liquid tile, no interpolation/tesselation performed. So those "omitted" values are actually never used from what i can tell.

Technically, the (maximum) amount of height values is liquid_height[ADT_CELLS_PER_GRID*(ADT_CELL_SIZE+1)][ADT_CELLS_PER_GRID*(ADT_CELL_SIZE+1)]

and not liquid_height[ADT_GRID_SIZE+1][ADT_GRID_SIZE+1]

Actually, System.cpp:675 does overwrite values, which is only okay if liquid data never has abrupt height changes between cells, but in any case the client data definitely allows it.

-edit-

I just modified extractor, in Northrend 3 values are overwritten with differing heights, and in Azjol_LowerCity 14 values are overwritten, so liquid meshes can be discontinuous across cell borders.

Probably a minor issue, but still current data is incomplete...

[faramir118]

bump

Also, perhaps parts of https://github.com/faramir118/mangos/commit/e0837e5dea62806028fbe028b1393b7874a454a4 should be included - would give even more correct data.

[Schmoozerd]

I step in with bumping - is this(what is this actually) still required?

Little Christmas present for Lynx to look into

[Schmoozerd]

In [11904]. Thank you

[tyrael]

faramir118 I hope you will have time sometimes to deal with terrain hole data..

Ty