[FIX] Destroy quest item

[Most_Mangos]

What bug does the patch fix? What features does the patch add?

Destroy quest item after handing over of quest`s

For which repository revision was the patch created?

10136

Is there a thread in the bug report section or at lighthouse?

none

Who has been writing this fix? Please include either forum user names or email addresses.

Valhalla-Project

diff --git a/src/game/Player.cpp b/src/game/Player.cpp
index 9e0ce9d..4773c03 100644
--- a/src/game/Player.cpp
+++ b/src/game/Player.cpp
@@ -13770,6 +13773,17 @@ void Player::RewardQuest( Quest const *pQuest, uint32 reward, Object* questGiver
            DestroyItemCount( pQuest->ReqItemId[i], pQuest->ReqItemCount[i], true);
    }

+    //Destroy quest item
+    uint32 srcitem = pQuest->GetSrcItemId();
+    if( srcitem > 0 )
+    {
+        uint32 count = pQuest->GetSrcItemCount();
+        if( count <= 0 )
+            count = 1;
+
+        DestroyItemCount(srcitem, count, true, true);
+    }
+
    RemoveTimedQuest(quest_id);

    if (BattleGround* bg = GetBattleGround())

[Revils]

uint32 count = pQuest->GetSrcItemCount();

if( count <= 0 )

if count is unsigned how it can be less than 0?

anyway I confirm that often questitems are no more removed after quest complete

edit:

same odd check present in Player::GiveQuestSourceItem, I think it's useless anyway since there's check already on load from DB

[VladimirMangos]

In general suggested code not safe. Exist special function for this: Player::TakeQuestSourceItem

[added] But as i know in past all expected to be removed startup items has been in list quest objectives for remove at quest reward....