[patch] Generic Type (5) GO Despawn with Use

[Auntie Mangos]

Description of the feature?

Allows to despawn Type-5 GOs with Use

For which repository revision was the patch created?

10409

Is there a thread in the bug report section or at lighthouse?

no

Who has been writing this patch?

me

In some rare cases we need to despawn Generic-Type GOs.

this should be done with GO::Use

However there is one very big problem:

There is no pattern which GO can be despawned, and which cannot, so there are only (at least without entirely new information) possibilities to get it done:

1) Allow despawning for all GOs

2) Allow despawning only for some entries

Further Research Information:

http://getmangos.eu/community/viewtopic.php?id=14368 - this only shows that "in the wild" only the Beacon torch is used (which is due to crap in the DBs) and hence we have a high chance that there is no unwanted side effect of allowing general despawn.

A few GOs:

** GOs that shall despawn: 179511, 179563, 183771,

190094(maybe UpdateEntry)

** GOs that shall not despawn: Don't know any type-5 GO, that is "Used" but shouldn't despawn..

** 176093 and 190094 have both data1=1, the rest of the GOs is all 0 => no information possible

Patch:

http://paste2.org/p/965633 (includes unifying comment style for the GO-type numbers)

the "heart" of this big patch is:

+        case GAMEOBJECT_TYPE_GENERIC:                       // 5
+        {
+            // Generic GO despawn - only good different approach is to slect despawnable GOs by Entry
+            SetLootState(GO_JUST_DEACTIVATED);
+            return;
+        }

In case you prefered a strict check:

http://paste2.org/p/965639

(though I think the general despawn possibility won't give any problems)

Edit:

Remove notes regarding beacon torch, was mistake in DBs..

[NoFantasy]

added in [10607] with an additional check in HandleGameObjectUseOpcode. Doesn't expect client to send anything for this GO type, and then error if it receive anything (hack attempt possibly?)