[Bug] IsHostileTo is not symmetric

[Auntie Mangos]

Poor rabit can't defend themselves if attacked ? i agree with Schmoozerd on this one, when attacked mob should defend themselves.

[Auntie Mangos]

Poor rabit can't defend themselves if attacked ? i agree with Schmoozerd on this one, when attacked mob should defend themselves.

On offy rabbits run away if attacked with dots, lol.

[Schmoozerd]

Mangos Version: 10438

Custom Patches: no related

SD2 Version: ~1815

Database Name and Version : udb392

How it SHOULD work: "I don't like anyone who doesn't like me"

How it DOES work: "Whom I like doesn't depend on who likes me" (a bit stupid)

Example:

Faction 119 and 63 is asymmetric:

63->IsHostileTo(119), but not 119->IsHostileTo(63)

This results in ugly aggro bugs (EnterCombat, not call AttackStart, leave combat on next tick)

You can construct the bug with:

in dungeons,

if we have three units, A B C, where A->IsHostileTo(B) but not B->IsHostileTo(A), and A attacks C,

if then A comes in range to B, B is set into combat, and evades on next Tick, and I think this is a bug

Suggestion was to make the IsHostileTo - faction check to be symmetric, but removed

(as stated by vladimir it is the wrong way to handle this thing)

[VladimirMangos]

Suggestion clearly wrong. Wolfs hostile to rabbit not make rabbits hostile to wolfs.

[Schmoozerd]

perhaps I should have described the - in my opinion - bug more detailed:

in dungeons,

if we have three units, A B C, where A->IsHostileTo(B) but not B->IsHostileTo(A), and A attacks C,

if then A comes in range to B, B is set into combat, and evades on next Tick, and I think this is a bug

and rabbits clearly should attack:

[fdb_]

BEware of the white rabbit !!! This one is awesome

[FeRkEl]

perhaps I should have described the - in my opinion - bug more detailed:

in dungeons,

if we have three units, A B C, where A->IsHostileTo(B) but not B->IsHostileTo(A), and A attacks C,

if then A comes in range to B, B is set into combat, and evades on next Tick, and I think this is a bug

the bug is that B shouldn't be set in combat till is realy attacked ? am i wrong?

[Curious]

If A come to range with B he shoud attack him an B respond by attacking A too.

[FeRkEl]

If A come to range with B he shoud attack him an B respond by attacking A too.

as far as i understood schmoozerd A is just attacking C so he can't attack B at this time, and B shouldn't be affected yet?

[frostic]

the rabbit attacks me on my server i think the wolf is just more powerful and kills the rabbit easy, even deer chase you down attacking you and cows too. if that is a bug leave it alone it makes ppl laugh when a cow chases you down lol

[Schmoozerd]

the bug is that B shouldn't be set in combat till is realy attacked ? am i wrong?

I am not sure what the bug really is

perhaps it would be correct to not only setincombat with, but to do some checks like

if (target->CanInitiateAttack()) target->AI()->StartAtack(this);