[patch] Fix spell 61632 Sartharion Berserk

[Auntie Mangos]

If this patch gets accepted, you may add this too: http://getmangos.eu/community/viewtopic.php?pid=127535#p127535

pretty similar to this...

[Revils]

* What bug does the patch fix? What features does the patch add?

Fix AOE spell 61632 that should affect only friendly units (boss's adds and not players).

* For which repository revision was the patch created?

10675

* Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

none that I know.

* Who has been writing this patch? Please include either forum user names or email addresses.

Revils

diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp
index 5aa713f..5e47727 100644
--- a/src/game/SpellMgr.cpp
+++ b/src/game/SpellMgr.cpp
@@ -700,6 +700,7 @@ bool IsPositiveEffect(uint32 spellId, SpellEffectIndex effIndex)
                case SPELL_AURA_MOD_SPELL_CRIT_CHANCE:
                case SPELL_AURA_MOD_INCREASE_HEALTH_PERCENT:
                case SPELL_AURA_MOD_DAMAGE_PERCENT_DONE:
+                case SPELL_AURA_MOD_HASTE:
                    if(spellproto->CalculateSimpleValue(effIndex) > 0)
                        return true;                        // some expected positive spells have SPELL_ATTR_EX_NEGATIVE or unclear target modes
                    break;
@@ -782,6 +783,7 @@ bool IsPositiveEffect(uint32 spellId, SpellEffectIndex effIndex)
                    switch(spellproto->Id)
                    {
                        case 802:                           // Mutate Bug, wrongly negative by target modes
+                        case 61632:                         // Sartharion Berserk
                            return true;
                        case 36900:                         // Soul Split: Evil!
                        case 36901:                         // Soul Split: Good

Since it's a spell with TARGET_CASTER_COORDINATES/TARGET_AREAEFFECT_INSTANT its targets depends by IsPositiveEffect so I add an exception for SPELL_AURA_MOD_SCALE and I add a rule for SPELL_AURA_MOD_HASTE (it's similar to SPELL_AURA_MOD_SPELL_CRIT_CHANCE) to make it positive.

I didn't find much info so I'm not sure if spell max affected targets must be limited (from data is 0) otherwise all mobs in instance will get the buff.

[NoFantasy]

Rejected, use DB table spell_script_target to control/limit valid targets.