[BUG] Blood Tap

[Forusim]

Mangos Version: 10784

Custom Patches: none

SD2 Version: 1884

Database Name and Version : UDB 394

How it SHOULD work:

Immediately activates a Blood Rune and converts it into a Death Rune for the next 20 sec. Death Runes count as a Blood, Frost or Unholy Rune.

How it DOES work:

Only convert part is working, if you have bloodrune available and not on cd.

I have investigated the problem and found that dbc entry for this spell has wrong effectmiscvalue.

As of this enum:

enum RuneType

{

RUNE_BLOOD = 0,

RUNE_UNHOLY = 1,

RUNE_FROST = 2,

RUNE_DEATH = 3,

NUM_RUNE_TYPES = 4

};

effectmiscvalue should be 0, but there is a 3.

So there are different ways of solving problems like this:

- correct dbc values = not supported by mangos

- hack the values in Spell::EffectActivateRune

- implement sql based spell.dbc which override dbc values by these in the database

If you see a better solution, please let me know.