[patch][spell=43723]Demon Broiled Surprise

[virusav]

After committing 10842, you can specify the target for spells 43723 in `spell_script_target`, but to implement cast 43753 still need to SPELL_EFFECT_DUMMY, because it is there goal TARGET_AREAEFFECT_INSTANT.

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index d553575..f198be3 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -1202,17 +1202,13 @@ void Spell::EffectDummy(SpellEffectIndex eff_idx)
                    unitTarget->CastSpell(unitTarget, 43059, true);
                    return;
                }
-                // Demon Broiled Surprise
-                /* FIX ME: Required for correct work implementing implicit target 7 (in pair (22,7))
-                case 43723:
+                case 43723:                                 // Demon Broiled Surprise
                {
-                    if (m_caster->GetTypeId() != TYPEID_PLAYER)
-                        return;
+                    if (m_caster->GetTypeId() == TYPEID_PLAYER)
+                        m_caster->CastSpell(m_caster, 43753, false); // Demon-Broiled Surprise

-                    ((Player*)m_caster)->CastSpell(unitTarget, 43753, true);
                    return;
                }
-                */
                case 43882:                                 // Scourging Crystal Controller Dummy
                {
                    if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT) 

For database:

DELETE FROM `spell_script_target` WHERE `entry`=43723;
INSERT INTO `spell_script_target` SET `entry`=43723, `type`=2, `targetentry`=19973;
DELETE FROM `spell_scripts` WHERE `id`=43723;

[Schmoozerd]

thanks, I would be very happy if this would finally be working

However I feel I should point to the fact that the first effect of spell 43723 is a script effect with basepoints=43753 which I think makes it more likely that the actual spell-casting should be handled with the second spell (but ofc this won't work)

[Curious]

Little bump

[virusav]

After 10908 patch is not needed.