[fixed][Mangos-0.12][Crash] BattleGroundQueue::Update

[mns]

rev : s0550

how reapply crash ? Players reported when join in Arathi Basin and Eye of the Storm after enter battle crashing server but i can`t reapply this in local test server .

over 20 crash in day

Cash log :

Exception code: C0000005 ACCESS_VIOLATION

Call stack:
Address   Frame     Function      SourceFile
0000000140366A60  000000000A58F940  BattleGroundQueue::Update+30  d:\\compail-folder\\35-[s0550]_1913\\src\\game\\battlegroundmgr.cpp line 752
00000001403699FF  000000000A58FC00  BattleGroundMgr::Update+61F  d:\\compail-folder\\35-[s0550]_1913\\src\\game\\battlegroundmgr.cpp line 1195
00000001402E7DCA  000000000A58FDC0  World::Update+6CA  d:\\compail-folder\\35-[s0550]_1913\\src\\game\\world.cpp line 1397
000000014006D926  000000000A58FE80  WorldRunnable::run+A6  d:\\compail-folder\\35-[s0550]_1913\\src\\mangosd\\worldrunnable.cpp line 66
0000000140317F03  000000000A58FED0  ACE_Based::Thread::ThreadTask+23  d:\\compail-folder\\35-[s0550]_1913\\src\\shared\\threading.cpp line 190
00000000006F24AB  000000000A58FF10  ?invoke@ACE_OS_Thread_Adapter@@UEAAKXZ+5B
0000000078622FDF  000000000A58FF40  _endthreadex+47
0000000078623080  000000000A58FF70  _endthreadex+E8
0000000077D6B71A  000000000A58FFA0  BaseThreadStart+3A

Local Variables And Parameters

Call stack:
Address   Frame     Function      SourceFile
0000000140366A60  000000000A58F940  BattleGroundQueue::Update+30  d:\\compail-folder\\35-[s0550]_1913\\src\\game\\battlegroundmgr.cpp line 752
   Local  <user defined> 'this'
   Local  <user defined> 'bgTypeId'
   Local  <user defined> 'bracket_id'
   Local  unsigned int 'arenaType' = 0
   Local  bool 'isRated' = 0
   Local  unsigned int 'arenaRating' = A58FFA8
   Local  <user defined> 'bg_template'
   Local  <user defined> 'next'
   Local  unsigned int 'MinPlayersPerTeam' = 1
   Local  unsigned int 'MaxPlayersPerTeam' = 0
   Local  <user defined> 'itr'

00000001403699FF  000000000A58FC00  BattleGroundMgr::Update+61F  d:\\compail-folder\\35-[s0550]_1913\\src\\game\\battlegroundmgr.cpp line 1195
   Local  unsigned int 'i' = 40
   Local  <user defined> 'scheduled'
   Local  unsigned int 'i' = 8
   Local  <user defined> 'this'
   Local  unsigned int 'diff' = 0
   Local  <user defined> 'next'
   Local  <user defined> 'itr'

Debug log :

2010-12-22 18:07:11 Battleground: removing player 71361 from bg queue for instance 57 because of not pressing enter battle in time.
2010-12-22 18:07:11 BattleGroundQueue: Removing player GUID 71361, from bracket_id 6
2010-12-22 18:07:11 Battleground: removing player 28454 from bg queue for instance 57 because of not pressing enter battle in time.
2010-12-22 18:07:11 BattleGroundQueue: Removing player GUID 28454, from bracket_id 6
.
.
.

I experience 6 day uptime before s0550 with s0498

[VladimirMangos]

Hmm, possible related to [s0548] Can you revet it, it must revert clear and look at stability.

[mns]

yea

I rollback server to s547 16 hour ago and not any crash again .

Crash cause [s0548]

[VladimirMangos]

You know conditions for crash?

[mns]

not yet

I could not bilden crash again in local server and trace problem .

maybe double delete BattleGround objects in special situation .

[VladimirMangos]

I revert commit in [s0554]. Related code has been rewriten some weeks later so i will reaplly and update when will ready backport later applied commit.

[mns]

Maybe cause forgotten [8815] backporting .