[Patch] ICC, Bronjahm, Soulstorm visual effects

[Schmoozerd]

What bug does the patch fix? What features does the patch add?

Implements periodic dummy ticks for spells 69008, 68870

For which repository revision was the patch created?

11064

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

don't hink so

Who has been writing this patch? Please include either forum user names or email addresses.

me

Thanks to NoFantasy for advise.

Source: Sniff, the triggeredSpells are cast OOC in this order, after some time found spell 69008 as aura in Object create.

Spell 68870 is casted, and after you get exactly the right number of casts for the triggered spells (with right time)

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index b723a02..7fea31d 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -7482,6 +7482,13 @@ void Aura::PeriodicDummyTick()
                        case 2: target->CastSpell(target, 55739, true); break;
                    }
                    return;
+                case 69008:                                 // Soulstorm (OOC aura)
+                case 68870:                                 // Soulstorm
+                {
+                    uint32 triggerSpells[8] = {68898, 68904, 68886, 68905, 68896, 68906, 68897, 68907};
+                    target->CastSpell(target, triggerSpells[GetAuraTicks() % 8], true);
+                    return;
+                }
// Exist more after, need add later
                default:
                    break;

Various notes, before they got lost:

1) order of the spells should be 68904, 68886, 68905, 68896, 68906, 68897, 68907, 68898

2) GetAuraTicks() starts with 1, not with 0 (so basicly errors 1) and 2) cancel each other out

3) more complicated: these spells should be cast with SMSG_SPELL_START - but also should behave like triggered spells, this seems to be some more generic problem