[11172][Patch] Implement "On-Login" achievents (type 74)

[Schmoozerd]

What bug does the patch fix? What features does the patch add?

This implements support for achievements of type 74 (pvp-title achievements and birthday achievements

For which repository revision was the patch created?

11167 1/2

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

no

Who has been writing this patch? Please include either forum user names or email addresses.

me

Patch:

http://paste2.org/p/1246611

Example entry for 5th birthday-achievement:

INSERT INTO achievement_criteria_requirement VALUES

(12562, 20, 5, 0);

Known problem:

The time calculation for years is a bit off to reality, as untill 2100 at least it is never more off than 18h (assuming "birthday time" is set to any time > 1901)

However I think we need a more generic and more powerfull way to calculate "calender-events" and hence I think this simple approach is good enough to go (anybody is free to tune a few hours by config)

[DasBlub]

uhmmm... where do you get the birthday for ACHIEVEMENT_CRITERIA_REQUIRE_NTH_BIRTHDAY from?

i only see you accessing a config value (which is set to the 28th August 2005 ?!?!), which would be the same for everyone?

[Schmoozerd]

the config can be modified by anyone who wants something special, and the "N-th" is defined by database entry (as in my example for the 5th birthday-achievement)

[DasBlub]

uhm... maybe i got it wrong. is it the birthday from the server or from the user?

[Undergarun]

uhm... maybe i got it wrong. is it the birthday from the server or from the user?

It's the World of Warcraft's birthday but can be configured to whatever server name birthday.

[Schmoozerd]

yes - on retail it is the "birthday" of wow.

I didn't use this date, but (ofc!)

MaNGOS got it's name on 28th August 2005

[VladimirMangos]

In [11172]. Thank you