Jump to content

[11176] Errors 11169_01_mangos_mangos_string.sql

Guest virusav

Recommended Posts

diff --git a/sql/updates/11169_01_mangos_mangos_string.sql b/sql/updates/11169_01_mangos_mangos_string.sql
index fba16dc..4d4d1f5 100644
--- a/sql/updates/11169_01_mangos_mangos_string.sql
+++ b/sql/updates/11169_01_mangos_mangos_string.sql
@@ -1,6 +1,6 @@
ALTER TABLE db_version CHANGE COLUMN required_11117_01_mangos_world_template required_11169_01_mangos_mangos_string bit;

-DELETE FROM mangos_string WHERE entry IN (376,377,378,379,380,381,382,383,384,385,386,387,388,389,390,391,392,393,394,395,396,397,398,1500,15001,1502);
+DELETE FROM mangos_string WHERE entry IN (376,377,378,379,380,381,382,383,384,385,386,387,388,389,390,391,392,393,394,395,396,397,398,399,1500,1501,1502);

INSERT INTO mangos_string VALUES
(376,'%u - |cffffffff|Hpool:%u|h[%s]|h|r AutoSpawn: %u MaxLimit: %u Creatures: %u GameObjecs: %u Pools %u',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL), 

As I understand it, requests are written to be used safely many times.

It would be nice if the developers themselves rolls requests at least 2 times, because In this case, the error pops up immediately, and not the first time such a joint.

Link to comment
Share on other sites

In [11176]. Thank you.

As I understand it, requests are written to be used safely many times.

Ok, if drop rev guards, then yes, most sql updates expected possibility re-apply if possible write in this way (if not modified table structure other limitaitons). But postily DELETE used for make sure drop custom conflicting data or old versions.

For mangos_string this is specially important because old data (localizations for example) can use different %s entries in string and this can be sources of crashes. And yes, mostly like queries tested in this way, just becase while developed its applied many times without guards and later applied single time for normal DB update case with guards as any users do it.

Ofc, sometime possible wrong cases pass as in discussed sql update...

Link to comment
Share on other sites

  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use