[beginner questions] This is the right way to solve this quest?

[jotapdiez]

Hi All!!

I'm trying to learn some things about quest fixing.

I'm working around the quest The Ransacked Caravan (http://www.wowhead.com/quest=11465) who needs to use Trained Rock Falcon (http://www.wowhead.com/item=34111) who has 2 effects:

Effect #1 Dummy Server-side script

Effect #2 Script Effect Value: 44327

Effect 1 is the Hawk flying to the target?

Effect 2 is Hawk Hunting (http://www.wowhead.com/spell=44327) who give an item to progress quest and summon a Dragonslayer Ambusher.

So, I made this fix and I want to ask all of you if this is the right way to solve this quest. I made this fix according with this video

who has a low quality.:

--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -929,6 +929,21 @@ void Spell::EffectDummy(SpellEffectIndex eff_idx)
                    }
                    return;
                }
+                               case 44323:                                // Hawk Hunting
+                               {
+                    if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT)
+                        return;
+                                       
+                                       if (roll_chance_i(50))
+                                       {
+                                               Creature* creatureTarget = (Creature*)unitTarget;
+
+                                               creatureTarget->ForcedDespawn();
+                                               
+                                               m_caster->CastSpell(m_caster, 44327, true);
+                                       }
+                    return;
+                               }
                case 17271:                                 // Test Fetid Skull
                {
                    if (!itemTarget && m_caster->GetTypeId()!=TYPEID_PLAYER)

This code make to when the item Trained Rock Falcon (item:http://www.wowhead.com/item=34111; the spell for this item Hawk Hunting http://www.wowhead.com/spell=44323) has a 50% chance to give to caster a Fjord Turkey (http://www.wowhead.com/item=34112) and summon a Dragonslayer Ambusher. According with wowhead and the video (see above) I have 2 question more:

- When the item is used, an hawk go to the target and come back. How can I make this effect?

- The 50% chance is to summon a Dragonslayer Ambusher and Fjord Turkey must be given to the target always, but when I do the spell summon the creature always. So, how can I made to not summon always the creature?

Hope Understand me.

Sorry for my english

Regards Juan Pablo from Argentina

PD: I will fix my english too soon.