Aura::HandleModThreat - need Caster?

[breakwater]

Hi,

I have problems with this function and the Spell 29232 . This Spell is casting, if the Spore(Naxxramas-Loatheb) dies. This function check the caster and whether the caster is alive.

Why we check the caster in this function? therefore this Spell doesn't work correct, because the caster (Spore) is dead.

I hope someone can tell me why we check the caster. Maybe we can delete this code part, because it has no meaning.

I have comment out this code part and this spell works very good. I can not check every spell with this aura effect, but i think, this make no problems.

This patchfile with

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index 4c5f511..fa6bbee 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -4966,10 +4966,10 @@ void Aura::HandleModThreat(bool apply, bool Real)
    if (!target->isAlive())
        return;

-    Unit* caster = GetCaster();
+    /*Unit* caster = GetCaster();

    if (!caster || !caster->isAlive())
-        return;
+        return;*/ 

    int level_diff = 0;
    int multiplier = 0;

Sry for my english

[Schmoozerd]

have you tried to cast the spell by spore with original caster loatheb?

[breakwater]

I doesn't think thats a fix for my problem, because the unapply doesn't work. Because Loatheb (caster) is dead -> no unapply

[breakwater]

An other realy Problem is the unapply after the dead of caster. If Loatheb or an other is caster an this creature dies, the aggro reduce or increase is not unapply.

[kbz]

i can confirm the second part, if caster dies, aura never gets to the "unapply" part leaving the threat modifier on the unit

[zergtmn]

I don't know reason behind adding caster check, for me it looks logically incorrect.

Check removed in 11469, thank you.