[11567][Patch] Spell - Meteor Fists

[Xfurry]

* What bug does the patch fix? What features does the patch add?

Implement dummy aura effect for http://www.wowhead.com/spell=66725 spells. There are 2 sets of spells, one used by the boss Koralon and the other one used by the Flame warders in Vault of Archavon.

* For which repository revision was the patch created?

11542

* Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

none

* Who has been writing this patch? Please include either forum user names or email addresses.

me

Patch:

http://paste2.org/p/1437031

[VladimirMangos]

I not sure that spell correct by 2 points:

1) exist 4 dummy spell 68161, 68160, 66808, 66725 and _4_ triggered spell 67333, 67331, 66809, 66765

with 120 base points for 3 cases and 125 for one

2) dummy spells have self targeting mode, so look like boss cast it to self.

triggered have chain targeting mode normal for hostile targeted spells, as i understand instead current cast to target it must cast from aura target (boss) to "nearby target within 10 yards"

Unit::SelectRandomUnfriendlyTarget ?

Ofc, maybe you have some info that confirm your way work.

[Xfurry]

I not sure that spell correct by 2 points:

1) exist 4 dummy spell 68161, 68160, 66808, 66725 and _4_ triggered spell 67333, 67331, 66809, 66765

with 120 base points for 3 cases and 125 for one

2) dummy spells have self targeting mode, so look like boss cast it to self.

triggered have chain targeting mode normal for hostile targeted spells, as i understand instead current cast to target it must cast from aura target (boss) to "nearby target within 10 yards"

Unit::SelectRandomUnfriendlyTarget ?

Ofc, maybe you have some info that confirm your way work.

My difficulty in fixing this spell is not the target, but way it should work.

Basically the creature casts one of (68161, 68160, 66808, 66725) on self. During the time the creature has the dummy aura it should do melee damage with the corresponding damage triggered spell (67333, 67331, 66809, 66765) on the creature->getVictim() (not on random target) which is shared with another close target (similar to a cleave effect).

So each melee attack made by the creature while it has aura 68161 should trigger 67333 on the victim.

[Schmoozerd]

Proc flag 0x00000004, chance = 100, charges - 0

=================================================

02 Successful melee attack

=================================================

Effect 0: Id 6 (SPELL_EFFECT_APPLY_AURA)

BasePoints = 1

Targets (1, 0) (TARGET_SELF, NO_TARGET)

Aura Id 4 (SPELL_AURA_DUMMY), value = 1, misc = 0 (0), miscB = 0, periodic = 0

this means, you need to add a SpellProcEvent (hardcoded by spell-id) to DummyAura proc

Edit: see SpellAuraProcResult Unit::HandleDummyAuraProc

[Xfurry]

Well I think this patch should do:

http://paste2.org/p/1442639

The second set of spells doesn't have proc flag so I need to add them in DB. I'm not sure if the following query is correct but it works fine.

insert ignore into spell_proc_event values
(66808,127,0,0,0,0,0,0,0,0,0,0,4,0,0,0,0),
(68160,127,0,0,0,0,0,0,0,0,0,0,4,0,0,0,0);

[VladimirMangos]

In [11567]. Thank you