[One] Improve Pets & Stealth

[rowman]

think petai ignores stealth in two cases

1)

dont attack rogues too early

2)

dont attack them any longer if they use stealth

diff --git a/src/game/PetAI.cpp 
b/src/game/PetAI.cpp index 9f9b4dd..32c1f09 100644 
--- a/src/game/PetAI.cpp 
+++ b/src/game/PetAI.cpp 
@@ -61,8 +61,11 @@ void PetAI::MoveInLineOfSight(Unit *u)          
{
             if(m_creature->IsWithinLOSInMap(u))
             { 
-                AttackStart(u); 
-                u->RemoveSpellsCausingAura(SPELL_AURA_MOD_STEALTH); 
+                if (IsVisible(u)) 
+                { 
+                    AttackStart(u); 
+                    u->RemoveSpellsCausingAura(SPELL_AURA_MOD_STEALTH); 
+                }
             }
         }
     } 
@@ -99,7 +102,7 @@ bool PetAI::_needToStop() const      
if(m_creature->isCharmed() && m_creature->getVictim() == m_creature->GetCharmer())          return true;   
-    return !m_creature->getVictim()->isTargetableForAttack(); 
+    return !m_creature->getVictim()->isTargetableForAttack() && IsVisible(m_creature->getVictim());
 }  

[Azelen]

Pets also ignore fake dead mobs in combat, they are still trying to attack them

[rowman]

yeah but this has nothing to do with this fix

you cant implement feign death in ->isTargetableForAttack() for example

- pet must be stopped if the hunter uses feign death, but if the pet is send to attack (to interupt feign death) this must be possible

[betagan]

*push*

patch looks good to me, why not accepting it? any comment from mangos devs?

[rowman]

bumb ;-)