Super jail stuff

[comix]

Can any one update this patch .

i have 2 Crash . 1- When jail Wrong name 2- When Unjail Wrong name .

Last Patch i found from (fallenangelX ) : http://pastebin.com/B0HurChA

thank you

[roby10]

[== c++ ==]
+    ObjectGuid GUID = sObjectMgr.GetPlayerGuidByName(cname.c_str());  
+   /* if (GUID == 0)  
+    {  
+        SendSysMessage(LANG_JAIL_WRONG_NAME);  
+        return true;  
+    }*/                                                /// commented out to restore build 5/13/2011 -- wrong name on jail search wont show till fixed

[comix]

it's not work , i fix Crash in Unjail but in jail still crash :

fix crash in Unjail :

@@ -2062,11 +2066,11 @@ bool ChatHandler::HandleUnJailCommand(char *args)

chr->CastSpell(chr,8690,false);

//chr->GetSession()->LogoutPlayer(false);

} else PSendSysMessage(LANG_JAIL_CHAR_NOTJAILED, cname.c_str());

return true;

}

- else

+ else if (!GUID == 0)

{

CharacterDatabase.BeginTransaction();

QueryResult *jresult = CharacterDatabase.PQuery("SELECT * FROM `jail` WHERE `guid`='%u' LIMIT 1", chr->GetGUIDLow());

CharacterDatabase.CommitTransaction();

@@ -2098,11 +2102,15 @@ bool ChatHandler::HandleUnJailCommand(char *args)

delete jresult;

return true;

}

}

+ else

+ {

+ SendSysMessage(LANG_JAIL_WRONG_NAME);

return true;

+ }

}

//Send mail by command

bool ChatHandler::HandleSendMailCommand(char* args)

{

[lillecarl]

else if (!GUID == 0) should be else if (GUID != 0)

Thing is that the code does not check if the user exists before it starts running the code for jailing the player that does not exist

ObjectGuid GUID = sObjectMgr.GetPlayerGuidByName(cname.c_str());

if (GUID == 0)

{

SendSysMessage(LANG_JAIL_WRONG_NAME);

return true;

}

This is correct code as i can read, maby you shall just comment the line SendSysMessage(LANG_JAIL_WRONG_NAME); and instead use

PSendSysMessage("The name does not exist go bang yo mom");

- LilleCarl

[comix]

@lillecarl, can you please update the patch ?