[HOTFIX][6930] Crashes within Player::_LoadArenaTeamInfo

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

prevents crashes while the arenateam loading in Player::_LoadArenaTeamInfo

we had ~30 crashes today with 600-700 players online tonight (in the morning maybe 100-200).

INFO: i couldn't test this patch on my own server because i have no arenateams on it (only testserver, just me who's on it... from time to time 1 or 2 testers). and our serveradmin isn't here yet, so he couldn't test it too...

For which SubVersion revision was the patch created?

a5a0702376c222572e7b6c8c48b2cae975398ae3 (last 2.4.3 version, but should be the same in 3.0.3)

Who has been writing this patch? Please include either forum user names or email addresses.

DasBlub

here is the commit in my git repo: http://github.com/DasBlub/mangos/commit/9f908e877d054ff9ab973082d631bb7199f292f6

here are the crashlogs: http://www.2shared.com/file/4503952/1778b8f/crashlogs_2008_12_22.html

EDITH says that here is the bugreport: http://getmangos.eu/community/showthread.php?p=53233#post53233

[The_Game_Master]

Mutch appreciated.

[Wyk3d]

Thanks, added in [6930]. Do you know how those invalid arenateams got in your DB though ? Normally a patch like this would be considered a hack without all the WHY and HOW parts answered, but in this case it's fine since we can't trust the validity of information taken from DB anyway.

[DasBlub]

thanks

no idea, we should theoretically have a clean db... but i think our serveradmin can give you a better feedback, because i've no access to our database. until now we had the other patch from balrok and last weeks we had some problems with the arena teams (you couldn't register an arenateam and so on)... maybe it cames from that.

have you any sql statement to check for "valid" teams? because i have no knowledge about the arena tables...

just as a question: is it possible to include this patch to the 0.12 trunk? because actually we are on this one (takes some time to say some thousends of testers to change their version )

[VladimirMangos]

Changes backported to mangos-0.12.