Fixed [Check for Generic Icons]

[Auntie Mangos]

so it's similar to http://getmangos.eu/community/topic/13425/fix-spells-with-same-icons/

[NoHad]

Fixed [Check for Generic Icons] : They were interrupting by themself if the icons were the same for example: mind numbing poison -> interrupted by abolish disease ( or something like that it's priest ability )

diff -r 012b2a6b1785f82f1a9bf58b3fe5910666a2af54 -r aacaf6e3d037d5321445c87c6c5b5e3c1d138c40 src/game/SpellMgr.cpp

--- a/src/game/SpellMgr.cpp Sat Dec 03 09:43:27 2011 +0100

+++ b/src/game/SpellMgr.cpp Mon Dec 12 14:39:44 2011 +0100

@@ -1982,6 +1982,22 @@

break;

}

+ // generic spells

+ if (!spellInfo_1->SpellFamilyName)

+ {

+ if (!spellInfo_1->SpellIconID

+ || spellInfo_1->SpellIconID == 1

+ || spellInfo_1->SpellIconID != spellInfo_2->SpellIconID)

+ return false;

+ }

+

+ // check for class spells

+ else

+ {

+ if (spellInfo_1->SpellFamilyFlags != spellInfo_2->SpellFamilyFlags)

+ return false;

+ }

+

// more generic checks

if (spellInfo_1->SpellIconID == spellInfo_2->SpellIconID &&

spellInfo_1->SpellIconID != 0 && spellInfo_2->SpellIconID != 0)

Enjoy

[Cupcake]

What do you mean by interrupting? You mean they overwrite themselfs, aka auras are not stacking?

[NoHad]

NO, when you have aura of mind-numbing poison from rogue.. And Priest use spell with the same icon ( Abolish Disease ) Poison is replaced with abolish disease , Icons with the same icon were interrupting

And the same for other spells with the same icon

[NoHad]

IDK , I've writed it by myself

[fr1nge]

Serious side effect - players can cast multiple ranks of the same spell on the same target.

[michalpolko]

Stacking of holders needs complete rewriting, not just hotfix like that.

I worked on it some time ago, I dont remember now who was the author of the base code I used (he can be found somewhere in Under Review section).

You can find some useful code here: https://github.com/michalpolko/mangos/tree/aura_stacking (a little outdated now) or on mangosR2 repository (there were some further implementations, most important - stacking of holders from different creatures in instances, I don't remember author now ;P) https://github.com/mangosR2/mangos

On my repo you can track changes with history of revision file: https://github.com/michalpolko/mangos/commits/aura_stacking/revision_aura_stacking.txt

I hope you will find something useful there