Jump to content

[patch] two pet talents (dummy procs)

Auntie Mangos

Recommended Posts

Problem with those Talents below is, that alle pet spells have the same SpellFamilyMask (and SpellFamilyName Hunter), so that we need to check the procSpell in addition. Don't know why blizz didn't gave them extra flags if they even introduced pet's own SpellFamilyName :-/

Improved Cower (http://www.wowhead.com/?spell=53180): No Problem at all with this hardcoded Check.

Guard Dog (http://www.wowhead.com/?spell=53178): The Proc isn't a problem neighter but the increased aggro, as we can't add a spellmod to the owner because of the already mentioned spellfamilyflags. A more easy sollution is just to add additional threat to the target in HandleDummyAurasProc() but the more mangos like way is my suggested sollution, as I think.

Silverback (http://www.wowhead.com/?spell=62764): Also no problem with additionally check.

Patch: http://github.com/pasdVn/mangos/commit/bc222160313c2f8decb21f616d3dd4e439b235e2

SQL part is needed, because all those dummy auras don't have any procflags. Quite strange, as normally, dummy auras used for procing other spells, have them. Maybe this is also a hint to implement them in another way (e.g. just hardcode in the spelleffects of the triggering spells) but I liked the idea more, to handle them with the trigger system:

/*Improved Cower*/
DELETE FROM `spell_proc_event` WHERE entry IN (53180, 53181);
INSERT INTO `spell_proc_event` (`entry` ,`SchoolMask` ,`SpellFamilyName` ,`SpellFamilyMask0` ,`SpellFamilyMask1` ,`SpellFamilyMask2` ,`procFlags` ,`procEx` ,`ppmRate` ,`CustomChance` ,`Cooldown`) VALUES 
('53180', '0', '9', '0', '268435456', '0', '16', '0', '0', '0', '0'),
('53181', '0', '9', '0', '268435456', '0', '16', '0', '0', '0', '0');

/*Guard Dog*/
DELETE FROM `spell_proc_event` WHERE entry IN (53178, 53179);
INSERT INTO `spell_proc_event` (`entry` ,`SchoolMask` ,`SpellFamilyName` ,`SpellFamilyMask0` ,`SpellFamilyMask1` ,`SpellFamilyMask2` ,`procFlags` ,`procEx` ,`ppmRate` ,`CustomChance` ,`Cooldown`)VALUES 
('53178', '0', '9', '0', '268435456', '0', '65536', '0', '0', '0', '0'),
('53179', '0', '9', '0', '268435456', '0', '65536', '0', '0', '0', '0');

DELETE FROM `spell_proc_event` WHERE entry IN (62764, 62765);
INSERT INTO `spell_proc_event` (`entry` ,`SchoolMask` ,`SpellFamilyName` ,`SpellFamilyMask0` ,`SpellFamilyMask1` ,`SpellFamilyMask2` ,`procFlags` ,`procEx` ,`ppmRate` ,`CustomChance` ,`Cooldown`)VALUES 
('62764', '0', '9', '0', '268435456', '0', '65536', '0', '0', '0', '0'),
('62765', '0', '9', '0', '268435456', '0', '65536', '0', '0', '0', '0');  

Note: Proc of "Guard Dog" will only work with : http://getmangos.eu/community/viewtopic.php?id=6469

Link to comment
Share on other sites

  • 39 years later...
  • 6 months later...
This topic is now closed to further replies.
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use