skinlayers

Hello all!

Just wanted to make you aware of some AHbot compile warnings I'm getting under Ubuntu. No biggy, but it might help you clean your code or track down errors in the future:

../../../src/game/AuctionHouseBot.cpp: In member function ‘void AuctionHouseBot::addNewAuctionBuyerBotBid(Player*, AHBConfig*, WorldSession*)’:
../../../src/game/AuctionHouseBot.cpp:578: warning: format ‘%f’ expects type ‘double’, but argument 3 has type ‘long double’
../../../src/game/AuctionHouseBot.cpp:633: warning: format ‘%f’ expects type ‘double’, but argument 3 has type ‘long double’
../../../src/game/AuctionHouseBot.cpp:643: warning: format ‘%f’ expects type ‘double’, but argument 3 has type ‘long double’
../../../src/game/AuctionHouseBot.cpp:667: warning: format ‘%f’ expects type ‘double’, but argument 3 has type ‘long double’
../../../src/game/AuctionHouseBot.cpp: In member function ‘void AuctionHouseBot::Initialize()’:
../../../src/game/AuctionHouseBot.cpp:812: warning: format not a string literal and no format arguments
../../../src/game/AuctionHouseBot.cpp:839: warning: format not a string literal and no format arguments

../../../src/game/Level3.cpp: In member function ‘bool ChatHandler::HandleAHBotOptionsCommand(const char*)’:
../../../src/game/Level3.cpp:163: warning: spurious trailing ‘%’ in format
../../../src/game/Level3.cpp:187: warning: spurious trailing ‘%’ in format

Thanks!

skinlayers

Blueboy:

Just thought you might want to be aware of a few playerbot compile warnings I'm getting under Ubuntu. No biggy, but I thought you might want to know:

../../../src/game/PlayerbotMgr.cpp: In member function ‘bool ChatHandler::HandlePlayerbotCommand(const char*)’:
../../../src/game/PlayerbotMgr.cpp:559: warning: format ‘%u’ expects type ‘unsigned int’, but argument 3 has type ‘uint64’
../../../src/game/PlayerbotMgr.cpp:582: warning: format ‘%u’ expects type ‘unsigned int’, but argument 3 has type ‘uint64’
../../../src/game/PlayerbotMgr.cpp:594: warning: format ‘%u’ expects type ‘unsigned int’, but argument 3 has type ‘uint64’

Also, when I generate a patch file and apply it I get 170+ trailing whitespace warnings. Any chance you can fix this in the repo? Again, not a big deal...

skinlayers

@kugel and UnkleNuke

You could try this one: http://gist.github.com/310405

I checked out Naicisums ahbot0.15 patch and merged up to 9310. Only merge probs were with VCx0/game.vcproj, but I hopefully fixed these (can't test, as I don't use windows). I haven't (and won't do so) tested the patch myself, but I'm quite positiv it will compile. If you spot some compile errors connected to ahbot, post them and I'll have a look.

And I don't think Vladimir reads in this thread that often, if you have a message for him you better post it someplace else ;-)

Be calm with Naicisum, he's a busy man.

Regards

Skirnir

Skirnir: You're actually missing a couple of files. Namely README.AHBOT, characters_auctionhousebot.sql, and characters_auctionhousebot_update.sql

skinlayers

Here's an updated patch I generated after manually merging AHbot with the current MaNGOS (9549)

http://skinlayers.net/evoxpatches/mangos-ahbot-9549.patch

cd mangos
wget [url]http://skinlayers.net/evoxpatches/mangos-ahbot-9549.patch[/url]
git apply mangos-ahbot-9549.patch
rm mangos-ahbot-9549.patch

Hopefully this will help those of you having issues with git or are just too lazy to generate your own diff

skinlayers

Blueboy,

Thank you for playerbot + patches. My testers love it, though it was causing seg fauls on my Debian Lenny 64-bit server. One of my players thinks its has to do with having bots in a instance... maybe a bot priest healing in an instance or having more than two bots. My current server is mucked up, so I'm going to recompile and see if that works better. Just wanted to say thanks.

skinlayers

I manually added in the code, and this is where it died during compile:

g++ -DHAVE_CONFIG_H -I. -I../../../src/game -I../..  -I../../../dep/ACE_wrappers -I../../dep/ACE_wrappers  -I/usr/include/mysql    -I../../src/shared -I../../../src/game -I../../../src/game/../../dep/include -I../../../src/game/../framework -I../../../src/game/../shared -I../../../src/game/../shared/vmap -I../../../src/game/../realmd -DSYSCONFDIR=\\"/opt/evox/etc/\\"   -DDO_MYSQL -g -O2 -MT Level2.o -MD -MP -MF .deps/Level2.Tpo -c -o Level2.o ../../../src/game/Level2.cpp
../../../src/game/Level2.cpp: In member function ‘bool ChatHandler::HandlePInfoCommand(const char*)’:
../../../src/game/Level2.cpp:2173: warning: NULL used in arithmetic
../../../src/game/Level2.cpp:2175: warning: NULL used in arithmetic
../../../src/game/Level2.cpp:2176: error: invalid conversion from ‘uint16’ to ‘AccountTypes’
../../../src/game/Level2.cpp:2178: error: invalid conversion from ‘uint32’ to ‘AccountTypes’
../../../src/game/Level2.cpp:2181: error: invalid conversion from ‘uint32’ to ‘AccountTypes’
make[3]: *** [Level2.o] Error 1

Admittedly, I'm running evo-X, not MaNGOS, but evox synced with MaNGOS just a day or two ago, so I'm willing to bet the same compile error exists in both.

Thanks,

skinlayers