Stillhard

Please try this: @@ -12400,16 +12400,10 @@ void Player::PrepareGossipMenu(WorldObject *pSource, uint32 menuId) pMenu->GetGossipMenu().SetMenuId(menuId); GossipMenuItemsMapBounds pMenuItemBounds = sObjectMgr.GetGossipMenuItemsMapBounds(menuId); - // Playerbot mod - Creature *pCreature = (Creature*)pSource; - - if (pCreature->isBotGiver()) - pCreature->LoadBotMenu(this); - // if default menuId and no menu options exist for this, use options from default options if (pMenuItemBounds.first == pMenuItemBounds.second && menuId == GetDefaultGossipMenuForSource(pSource)) pMenuItemBounds = sObjectMgr.GetGossipMenuItemsMapBounds(0); for(GossipMenuItemsMap::const_iterator itr = pMenuItemBounds.first; itr != pMenuItemBounds.second; ++itr) @@ -12429,10 +12423,14 @@ void Player::PrepareGossipMenu(WorldObject *pSource, uint32 menuId) { Creature *pCreature = (Creature*)pSource; uint32 npcflags = pCreature->GetUInt32Value(UNIT_NPC_FLAGS); + // Playerbot mod + if (pCreature->isBotGiver()) + pCreature->LoadBotMenu(this); + if (!(itr->second.npc_option_npcflag & npcflags)) continue; switch(itr->second.option_id) { 17 hours with no crash here

Well alot of things changed with the gossip system, i dunno... But back there, one thing for sure that my server crashed once a player click a GO to finish his quest, (i can't remember what GO was) etc, that was related to new gossip/dialog system. It is great that you've managed to solved it. I'll try to be more responsive to this thread next time. Thank you blueboy

Yes i use the bot guy (i'm going to make a petition to save the bot guy ). I can tell you that everything working... i've tested 100% no crashed for the bot guy or playerbot.

You ppls having a crash with playerbot? I did just once and i forgot to tell you all here that i manage to fixed it (look for the date i fixed it here http://www.getmangos.eu/community/showpost.php?p=96530&postcount=159) The culprit is here in Player.cpp: Yours: GossipMenuItemsMapBounds pMenuItemBounds = sObjectMgr.GetGossipMenuItemsMapBounds(menuId); ... // Playerbot mod Creature *pCreature = (Creature*)pSource; if(pCreature->isBotGiver()) pCreature->LoadBotMenu(this); // if default menuId and no menu options exist for this, use options from default options Mine: for(GossipMenuItemsMap::const_iterator itr = pMenuItemBounds.first; itr != pMenuItemBounds.second; ++itr) { bool bCanTalk = true; if (itr->second.cond_1 && !sObjectMgr.IsPlayerMeetToCondition(this, itr->second.cond_1)) continue; if (itr->second.cond_2 && !sObjectMgr.IsPlayerMeetToCondition(this, itr->second.cond_2)) continue; if (itr->second.cond_3 && !sObjectMgr.IsPlayerMeetToCondition(this, itr->second.cond_3)) continue; if (pSource->GetTypeId() == TYPEID_UNIT) { Creature *pCreature = (Creature*)pSource; uint32 npcflags = pCreature->GetUInt32Value(UNIT_NPC_FLAGS); if(pCreature->isBotGiver()) pCreature->LoadBotMenu(this); if (!(itr->second.npc_option_npcflag & npcflags)) I hope you can understand me there...

I just compared your rep NPChandler.cpp with the official MaNGOS one... Yours missed many lines there...

Edited: REMOVED! Fixed - false alarm - Sorry guys

Add this to the bottom of your GameObject.cpp void GameObject::DealSiegeDamage(uint32 damage) { m_actualHealth -= damage; // TODO : there are a lot of thinghts to do here if(m_actualHealth < 0) { m_actualHealth = GetGOInfo()->destructibleBuilding.intactNumHits; SetLootState(GO_JUST_DEACTIVATED); } }

Can you fix the code attached above? Edited: Please use code tag in the future...

MaNGOS too... well... at .ru at least... just wait...

Interesting idea. Thank you for the valuable informations.

You're crazy :lol:

Yes Vlad, you're correct and some fixes already made in getmangos.ru before they went down but it just need some improvement and little tweak to make it work with the patch you've mentioned.

Ahhh.. i see that, thank you Ambal. I'll fix them my self. Truly sorry that i put those here, because i never see anything like those before and because getmangos.ru always been like down forever... Edited: My problem fixed now. Thank you again ambal for pointing me the problem and the fix. The memory allocator is running great from the first time i test and now commited.

I'm sorry to ask here Ambal, but what is these? 14:09:59 InstanceMap::SetResetSchedule: cannot turn schedule on, no save availab le for instance 1 of 602 ..\\..\\src\\game\\ObjectMgr.cpp:5802 in ObjectMgr::GenerateLowGuid ASSERTION FAILED : 0 WorldObject::SummonVehicle() d:\\sourcecodes\\mangos\\src\\game\\object.cpp: 1692 + 0 x27 WorldSession::HandleSpellClick() d:\\sourcecodes\\mangos\\src\\game\\spellhandler.cpp : 587 + 0xbf WorldSession::Update() d:\\sourcecodes\\mangos\\src\\game\\worldsession.cpp: 196 + 0x 0 World::UpdateSessions() d:\\sourcecodes\\mangos\\src\\game\\world.cpp: 2082 + 0x29 World::Update() d:\\sourcecodes\\mangos\\src\\game\\world.cpp: 1625 + 0x0 WorldRunnable::run() d:\\sourcecodes\\mangos\\src\\mangosd\\worldrunnable.cpp: 65 + 0 x0 ACE_Based::Thread::ThreadTask() d:\\sourcecodes\\mangos\\src\\shared\\threading.cpp: 186 + 0x0 _WSAFDIsSet()+0xfffc108f [0x6170b] endthreadex()+0x47 [0x2fdf] endthreadex()+0xe8 [0x3080] BaseThreadStart()+0x3a [0x2b71a] ..\\..\\src\\game\\ObjectMgr.cpp:5805 in ObjectMgr::GenerateLowGuid ASSERTION FAILED : 0 WorldObject::SummonVehicle() d:\\sourcecodes\\mangos\\src\\game\\object.cpp: 1692 + 0 x27 WorldSession::HandleSpellClick() d:\\sourcecodes\\mangos\\src\\game\\spellhandler.cpp : 587 + 0xbf WorldSession::Update() d:\\sourcecodes\\mangos\\src\\game\\worldsession.cpp: 196 + 0x 0 World::UpdateSessions() d:\\sourcecodes\\mangos\\src\\game\\world.cpp: 2082 + 0x29 World::Update() d:\\sourcecodes\\mangos\\src\\game\\world.cpp: 1625 + 0x0 WorldRunnable::run() d:\\sourcecodes\\mangos\\src\\mangosd\\worldrunnable.cpp: 65 + 0 x0 ACE_Based::Thread::ThreadTask() d:\\sourcecodes\\mangos\\src\\shared\\threading.cpp: 186 + 0x0 _WSAFDIsSet()+0xfffc108f [0x6170b] endthreadex()+0x47 [0x2fdf] endthreadex()+0xe8 [0x3080] BaseThreadStart()+0x3a [0x2b71a] 15:49:11 HandleMoveNotActiveMover: incorrect mover guid: mover is 00000000000001 67 and should be 0000000000000167 instead of 359 15:52:26 WorldSocket::HandlePing: Player kicked for over-speed pings address = 2 03.206.121.187 16:00:01 GameEvent 16 "Gurubashi Arena Booty Run" removed. 16:00:01 GameEvent 29 "Nights" removed. 16:00:01 Next game event check in 3600 seconds.

Working fine here... Make sure correct datas entered.

1>Microsoft (R) Macro Assembler (x64) Version 9.00.30729.01 1>Copyright (C) Microsoft Corporation. All rights reserved. 1>generating tbb.def file 1>win64-tbb-export.def 1>Compiling... 1>cl : Command line warning D9025 : overriding '/W3' with '/W4' 1>cl : Command line warning D9035 : option 'Wp64' has been deprecated and will be removed in a future release 1>tbb_thread.cpp 4>inftrees.c 6>Exception.cpp 1>concurrent_hash_map.cpp 1>cache_aligned_allocator.cpp 6>Creating library... 1>Compiling... 1>cl : Command line warning D9025 : overriding '/W3' with '/W4' 1>cl : Command line warning D9035 : option 'Wp64' has been deprecated and will be removed in a future release 1>itt_notify_proxy.c 7>MemoryAllocator.cpp 2>SV_Message_Queue.cpp 2>SV_Message.cpp 2>SUN_Proactor.cpp 7>..\\..\\dep\\tbb\\src\\tbbmalloc\\MemoryAllocator.cpp(1322) : warning C4018: '>' : signed/unsigned mismatch 7>..\\..\\dep\\tbb\\src\\tbbmalloc\\MemoryAllocator.cpp(1325) : warning C4018: '>' : signed/unsigned mismatch 7>..\\..\\dep\\tbb\\src\\tbbmalloc\\MemoryAllocator.cpp(1328) : warning C4018: '>' : signed/unsigned mismatch 7>dynamic_link.cpp 2>String_Base_Const.cpp 2>SOCK_Dgram_Bcast.cpp 8>..\\..\\src\\framework\\Policies\\MemoryManagement.cpp(25) : warning C4290: C++ exception specification ignored except to indicate a function is not __declspec(nothrow) 8>..\\..\\src\\framework\\Policies\\MemoryManagement.cpp(32) : warning C4290: C++ exception specification ignored except to indicate a function is not __declspec(nothrow) 2>SOCK_Dgram.cpp 2>SOCK_Connector.cpp Compiler: VC++ 2008 64bit

Very good, thank you!

+1 Thank you

Anyone saw and confirmed this?

<div class='quotetop'>QUOTE (w12x @ May 16 2008, 02:24 PM) <{POST_SNAPBACK}></div> <div class='sqlmain'>DELETE FROM creature WHERE id IN (18564, 18581); </div>This'll do it. And sorry again.[/b] It's OK m8, just want some confirmation before i test, that picture i sent you, it has double NPC Horde Field Scot there which is look like 1, this queries fixed them too? Thank you

<div class='quotetop'>QUOTE (w12x @ May 16 2008, 12:17 PM) <{POST_SNAPBACK}></div> I did... and re-did, but still... i'll send the screenshot to you via PM.

There are 2 NPC Horde Field Scot in Zabra'jin and they are both vendor. I can't continue recieve the flag in zangarmarsh. And that's the only problem. What's wrong?