TOM_RUS

There's this new mail stationery type "MAIL_STATIONERY_ORP" wonder what it's used for.

http://db.mmo-champion.com/i/46830/

There's missing comma in your patch...

>>>> mailType pl->GetGUIDLow()

It should be 1 day (blizzlike). Dunno who made it 30 days...

Try to check for:

if( messagetype == MAIL_CREATURE)

{

...

}

Today I finally managed to make my sniffer decrypt warden packets properly. There's 3 sessions logged (only warden packets)

http://paste2.org/p/454231

http://paste2.org/p/454237

http://paste2.org/p/454240

Ability to speak while dead is client side limitation, we can't do anything about that.

Memory address figured out by using IDA Pro disassembler and it's Hexrays plugin.

What mangos branch, client version you are using?

You should first check if player is in group, then broadcast packet to the group (may be in limited range?).

Something like that:

if(GetTypeId() == TYPEID_PLAYER)
{
   if(Group *group = ((Player*)this)->GetGroup())
   {
       WorldPacket data(SMSG_PARTYKILLLOG, (8+8)); //send event PARTY_KILL
       data << uint64(GetGUID()); //player with killing blow
       data << uint64(pVictim->GetGUID()); //victim
       group->BroadcastPacket(&data); // there's some more arguments available...
   }
}

This probably because SMSG_PARTYKILLLOG isn't implemented yet.

Structure of this opcode is:

SMSG_PARTYKILLLOG
uint64 guid1; // caster?
uint64 guid2; // target?

This feature will be implemented when it will be implemented on live servers (aka battle.net accounts: cross faction, cross game, cross realm chat) if someone reverse how battle.net 2 protocol works.

Or change false to true, may be it will work...

This patch is unstable.

Tested on a server with 500 players, crashes after a while.

Rev: 8342

Crash data: http://www.pastebin.ca/1523024

Crash log you posted not related to this patch.

I have sniffer written in C#. You only can call functions from dll using PInvoke. Is it useful?

http://msdn.microsoft.com/en-us/magazine/cc164123.aspx

I did some sniffing, and found that RC4 keys are changed after client receives 0x05 warden opcode:

http://paste2.org/p/326603

Has anyone made a WoW packet logger in any language that can use a dll? I don't want to write all that

Why you need that?

git diff HEAD should work then...

Yes, I understand that would work. I'm simply asking when people have actually seen this on retail servers. I'd rather have the server send this out when WoW actually is looking for it.

Also, how do you create a patch which contains added files?

http://i44.tinypic.com/2z88dad.jpg

And for patch files: git diff > file.patch (don't think it will include binary files).

Whoot!!!!!

Loading Warden System...
Warden System Loaded

User logs in

Warden Seed:     95ADF5753747995905AC96D1DC6A7E2DC96E1B4D8324A605067B68B3192E613B7D527AB42227527F
Warden Out Seed: B98ADD9ACDF9CBCF332C1B23B94CF58F
Warden In Seed:  C0900D9A2983B193D06A2B20350FA722
Warden Crypt Keys Generated!
Warden send packet: Len: 37
SESSION: received unexpected opcode CMSG_WARDEN_DATA (0x02E7) the player has not
logged in yet

When exactly is Warden initially sent on the real server? I have it sent before logging in after verification simply because that was simplest.

Change Opcodes.cpp

   /*0x2E7*/ { "CMSG_WARDEN_DATA",                             STATUS_LOGGEDIN, &WorldSession::HandleWardenDataOpcode          },

to

   /*0x2E7*/ { "CMSG_WARDEN_DATA",                             STATUS_AUTHED, &WorldSession::HandleWardenDataOpcode          },

Hmm, if I get it right Warden would allow the server administrators to run any code they like on the clients (simply by writing some new Warden module)?

I don't think that this is something we would like to support here.

There's signature in warden module and client checks it before loading...

Why not use http://www.wowhead.com/?spell=57818 aura check? If aura present, you then check tabard faction without hardcoding it.

if(HasAura(57818))
{
   Item* pItem = GetItemByPos( INVENTORY_SLOT_BAG_0, EQUIPMENT_SLOT_TABARD )
   if(item)
       tabardFactionID = item->GetProto()->RequiredReputationFaction;
}

Take a look at void Player::BuildPlayerTalentsInfoData(WorldPacket *data) (Player.cpp). There's a loop through talents tabs and talents in it.

I hope you will stay at 3.0.9... For a simple reason: DK is not even working like supposed and many 3.0 stuff is still bugged... Instead of releasing 3.1.2 full of bugs there should be a kinda "bug free" version of 3.0.9 which will make it much easier for 3.1.0 development.

You are wrong. Delays produce even more bugs because too much things changing over time.

Use RSS

Wrong fix, it will break packets order...

this is possible unrelated bug...

ffa pvp flag probably not fixed yet...

MaNGoS now supports the latest client version 3.0.3 build 9183. Enjoy it!

Please update yours dbc, maps and vmaps.

To convert your current characters and their items use following sql updates:

2008_12_22_18_characters_characters.sql
2008_12_22_19_characters_item_instance.sql

MERRY CHRISTMAS!

PS: 2.4.3 may continue to be be supported for some time. The "mangos-0.12" branch has been created for it where some fixes may be backported from master if we have time. To create and switch to a local branch named 243 that points to the mangos-0.12 remote branch, you may use the following command: git checkout -b 243 origin/mangos-0.12