virusav

There are spells that have the effect of the aura 135 (SPELL_AURA_MOD_HEALING_DONE), but additional treatment is not observed visually in becoming a player. When casting a spell on the treatment of bonus is also not visible. I looked through all spells with an aura of 135, who should be such a situation (for example, sorting 67684): 26276 37436 55637 60565 60566 60567 60568 60569 60570 63283 67684 70244 In Unit.cpp in int32 Unit:: SpellBaseHealingBonusDone (SpellSchoolMask schoolMask) is a condition: if (((* i) -> GetModifier () -> m_miscvalue & schoolMask)! = 0) but for these spells: (* I) -> GetModifier () -> m_miscvalue = 0 schoolMask = SPELL_SCHOOL_MASK_ALL / / 127 As a result, 0 & 127 = 0, so by the condition of the bonus is not calculated. It seems to me, it is necessary to change the condition that such bonuses spells practiced. Options: if (((* i) -> GetModifier () -> m_miscvalue & schoolMask)! = 0 | | (* i) -> GetModifier () -> m_miscvalue == 0) if (((* i) -> GetModifier () -> m_miscvalue & schoolMask)! = 0 | | schoolMask == SPELL_SCHOOL_MASK_ALL) Do yourself for the test set if (((* i) -> GetModifier () -> m_miscvalue & schoolMask)! = 0 | | ((* i) -> GetModifier () -> m_miscvalue == 0 & & schoolMask == SPELL_SCHOOL_MASK_ALL)) With such a condition all of the above spells visually give a bonus to treatment to become a player when casting spells + for treatment noticeable bonus. Checked some spells to choose from with an aura of 135 not out of the list - bonuses are not changed. I looked through all the places whence comes from entering SpellBaseHealingBonusDone, but found no call in a block with a condition that changes, ie altered condition does not violate the work of other spells. In addition, before the loop is AuraList const & mHealingDone = GetAurasByType (SPELL_AURA_MOD_HEALING_DONE); Ie select all with this type of auras, ie others here, even can not penetrate. What anyone thought about this, can one edit the data in such a way spells?

Currently, the team SCRIPT_COMMAND_TALK can search for NPC within a certain radius. In the case of flight taxi NPC is far away, so part of the sentence says the player. With this patch may find the following additional options: 1. datalong2 > 0, datalong3 = 0, datalong4 > 0 - will search for NPC by guid (the case with the flight to taxi) 2. datalong2 > 0, datalong3 > 0, datalong4 > 0 - will search for NPC by guid. If nothing was found, it will search for Entry in radius. Provides error log when misaligned parameters datalong2, datalong3 and datalong4. The rest of the patch does not affect functionality, founded in commit 9889. Revision of the kernel: 9984 Author: I Patch: http://paste2.org/p/854073

At the kernel 9948 spell 51840 work. Spell 8913 also earned. Thank you.

What suggestions about other items?

Already seen this commit, the evening will try to test the spell.

One compared the speed to taxi on Mangos and on the official server (on video) on quests and came to the conclusion that the speed is different: at Mangos quest flying mounts faster. I stumbled on this problem when trying to implement the quests http://www.wowhead.com/quest=9718 and http://www.wowhead.com/quest=12028. According to the player's quest 12028 47189 cast a spell lasting 2:40, the flight to taxi a little less (on the official server), and on the flight Mangos 1:40, ie a minute less. At the end of the spell quest must be completed, but due to the difference in a minute quest will not work correctly. Spell 47190 811 runs a taxi, who during the flight is 6 Events, each of which I have ordered a phrase that NPC should speak to the player. Timing your move in every point with the start of the opening event of the flight on the official server and Mangos. By dividing the relevant periods of time have come to the conclusion that the rate at Mangos should be 1.6 times smaller. The database found the NPC on the two quests, which serve as mounts with the invisible model. 17972 - Invisible Mount Speed 30 21396 - Invisible Mount Speed 20 By default speed taxi: # define PLAYER_FLIGHT_SPEED 32.0f In the quest 12028 21396 Mount. If we take into account that in the name of the specified speed while mounted on it for a taxi, find the deceleration rate: 32 / 20 = 1.6, which coincides with the calculated value. I made changes to the kernel: inline float Traveller <Player>:: Speed () ( if (i_traveller.isInFlight ()) ( float PlayerFlightSpeed = PLAYER_FLIGHT_SPEED; if (! i_traveller.m_taxi.empty ()) ( switch (i_traveller.m_taxi.GetCurrentTaxiPath ()) ( case 512: / / Stormcrow Amulet - spell 31606 PlayerFlightSpeed = 30.0f; break; case 811: / / Toalu'u's Spiritual Incense - spell 47190 PlayerFlightSpeed = 20.0f; break; ) ) return PlayerFlightSpeed; ) else return i_traveller.GetSpeed (i_traveller.m_movementInfo.HasMovementFlag (MOVEFLAG_WALK_MODE)? MOVE_WALK: MOVE_RUN); ) As a result, the player continues to fly the entire route for 1:40, but after landing, there are not NPC, objects, the player actually sits on an invisible mounted. It lasts about a minute. Event to run, as it should. It turns out that changing real flight player on the server, and the visual representation of the client remains the same. 1. Maybe should be sent to the client any package to change the speed, for example, MSG_MOVE_SET_FLIGHT_SPEED, etc.? 2. Can I change the speed not the Traveller <Player>:: Speed (), and in the description of effect spell, which is imposed on a player in the early flight? 3. Has anyone seen another taxi without mounts or a rate different from the official server? 4. Is it possible to make the NPC say the phrase in the player, regardless of distance, for example, by guid NPC? In the quest to 12028 player flies away, so much of phrases he speaks.

1. Commit [9856] Add dummy effect of spell 51840 Implementation of the kernel does not work, ie that when the object unitTarget first live, but at the moment, for example, case 1: unitTarget-> CastSpell (m_caster, 51837, true); break; NPC dies. It is possible that NPC die a little earlier, and therefore may not cast the spell. After entering the command .respawn object visible. 2. Spell http://www.wowhead.com/spell=8913 cast at all in the radius, including the player. Direct cast spell on the desired NPC leads to a transformation that in another NPC. In a simple usage of this item is not happening.

After 9830 when trying to commit to Complete quest through a table `event_scripts` in the log we get this error: 2010-05-03 23:05:01 ERROR: SCRIPT_COMMAND_QUEST_EXPLORED call for non-creature and non-gameobject (TypeId: 4), skipping. This mini-patch allows you to command SCRIPT_COMMAND_QUEST_EHPLORED if source = target = player. diff --git a/src/game/Map.cpp b/src/game/Map.cpp index c86066c..28c56ca 100644 --- a/src/game/Map.cpp +++ b/src/game/Map.cpp @@ -3228,9 +3228,9 @@ void Map::ScriptsProcess() if(target->GetTypeId()==TYPEID_PLAYER) { - if(source->GetTypeId()!=TYPEID_UNIT && source->GetTypeId()!=TYPEID_GAMEOBJECT) + if(source->GetTypeId()!=TYPEID_UNIT && source->GetTypeId()!=TYPEID_GAMEOBJECT && source->GetTypeId()!=TYPEID_PLAYER) { - sLog.outError("SCRIPT_COMMAND_QUEST_EXPLORED call for non-creature and non-gameobject (TypeId: %u), skipping.",source->GetTypeId()); + sLog.outError("SCRIPT_COMMAND_QUEST_EXPLORED call for non-creature, non-gameobject and non-player (TypeId: %u), skipping.",source->GetTypeId()); break; } The test location on the route taxi is not yet done. If necessary, it can be added.

Using the result of either cast a spell 50141, which apparently uses aura 50001, which is cast spell 50016 - quest complete. According to the man with the official server, use the result of either - the quest completed. Using the result of either or caste spell 50141 does not occur. There are similar situations with spells, how to fix the work spells in such cases?