Wyk3d

You do need to know the spell system to work with those properly as Vlad said, but in general, having multiple categories for patches is not a bad idea I think. It would take some work to make good helpful categories but if done well it could help when someone wants to work on some subsystem in getting an overview of what patches have been written for that. We have a lot of devs on the team but most come and go. Getting a quick listing of patches in their field of specialty could let them know what others have worked on to avoid duplication and perhaps keeps some patches from being lost. This would also come with more maintenance issues though and the overall benefit may be small so it's unclear whether it's worth it ..

The way I see it it's important that you test patches but from a patch review standpoint it's just a hint if it's at least worth considering, a minimum requirement. Nobody cares how many noobs say it works and ask for the patch to be added, in fact it's more annoying when they do. In part this discrepancy comes from the fact that users think in short term, they want features NAO!!, while we try to think more in the long term, how we can manage this huge pile of code while converging towards something perfect. A patch needs to be a lot of other things in order to be "correct" like efficient, elegant, extensible, concise, consistent, leak free etc etc etc. You cannot prove that a patch is "correct" by testing, only that it's incorrect. It can only be proven by actually providing a proof which is in the vast majority of cases not done so that delays the review as the developer has to do it himself and may result in him losing interest in the patch altogether .. And interest is the most important word here, this is all voluntary work and most people won't do things they don't like doing. Everyone has different interests and some people just pick random things to do while others have their own priority scale and will gravitate towards things they see as more important. The point is nomatter how important YOU think something is, you cannot force someone else to do it. You can reason why it would be good idea to do something but in the end it's entirely up to them. You can only measure someone by what they do and not what they don't do. Other things factor in like whether a certain developer knows a certain part of the code well or whether he remembers to look up older patches and bugs and so on but all of these lead to the same conclusion .. The more people the bigger the chance that someone will pick something up. Unfortunately there are few of us doing active work so things go slow .. we're open to suggestions on how to improve this but idiots who start their own projects don't help ..

Don't use online translators ?

It is impossible to get only mangos-0.12 or master or any particular version, you always _get it all_. This is equivalent to cloning and then using the command mentioned in the announcement but I guess this one would be less verbose if you are starting from scratch. It is however a waste of time unless you are downloading mangos for the first time or you want to create an additional source tree (and even then you could set up a shared repository without downloading again though that can be more complicated depending on the platform). EDIT: And you need to change directory after cloning that's why it didn't work for you.

It is probably just a minor error made by those who worked on the build system .

If however 1234 is present in both master and mangos-0.12 you may not get the one you want..

It does it as I said above with the library being properly loaded dynamically, only when LoadScriptingModule is called. You also have the possibility of building SD2 from its own separate solution on windows.

It's the other way around .. the scripting library is linked against the core (though i can only vouch for this on Windows). You cannot say that you are patching the sources when changing scripts because doing so does not actually change the mangosd executable (even if you rebuild with the common build system) so they are not part of its source. Technicly the library is not needed to run the application although there is a hardcoded check at startup and it is considered a fatal error (so the server exits) if it is not found. The library however is not required to actually contain any actual scripts and the default library included in the source tree does not. After you have built the core, you can rebuild just the scripts any number of times without the rest and it does work (or rather you build everything but if you only changed the scripts then mangosd did not change so only the scripts get built). You can also switch between multiple scripting libraries without having to rebuild mangosd, as long as they were all built against the same core. It is only as minor incovenience to have to rename them. Yes that would prevent you from reloading it at runtime however it could be fixed by looping all creatures and removing their AIs and adding them back after the library is loaded again, doesn't need any rewriting. So the implementation may have some bugs and missing features which vary in degree with the platform used but overall the library is not hardlinked or hardwired or whatever.

For example when creatures chase you they try to stay at map height. If the height is calculated wrong they appear slightly above or below the ground level.

Have you looked at the code ? The script library is loaded dynamically and can even be reloaded at runtime.

The main thread does exactly that. The freeze detector thread also does something similar.

There are a LOT of serious SD2 errors! They could be causing some of the core bugs/crashes/freezes but it's impossible to fix them if you don't use clean SD2. Did you reproduce it while running under valgrind ? The first log ends with a freeze and the second one seems to be shut down/terminated.

Does it matter if you don't appear in the exact same location just any random location near the battlemaster ?

Can there be more than one location for a player of a certain faction to be teleported to a specific battleground ?

Why all those extra columns ? I might understand id and team but why map,x,y,z,o ? Isn't the player location enough ?

Did you do this after you installed java ?

Much more people could help you if you would just report what error/problem you are having, in detail.

That would be great, just remember that in order to use purify on windows you need to:- switch to Debug mode - remove #include <vld.h> from MemoryLeaks.h - for EACH project (where you have linker options), including SD2!, set the following: Linker->Advanced->Fixed Base Address->Generate Relocation Seciont (/Fixed:No) Linker->General->Enable Incremental Linking -> No (/incremental:no) - full rebuild everything

Since you're using clean mangos, please also use clean SD2. I've gotten complaints that some of the errors that show up in your logs are not present in SD2.

So if i understood correctly, this works now and the patch is no longer needed / can be closed ?

Thanks a lot for that report, it was added back by mistake during the 303 merge, fixed in [7120].

Thanks a lot for that report, it was added back by mistake during the 303 merge, fixed in [7119].

If by "that" you mean the last freeze you posted in the crash report thread then it's fixed. Could you please post which revision you made those logs with ?

Fixed in [7119] thank you.

Use that to get started with purify on linux: http://www.stanford.edu/class/cs107/documents/aman-loves-purify.html