xeross155

MangChat is working fine, I just fixed a linux crash in MCS_OnlinePlayers and will continue to improve it. might create a public branch for it.

An external ticket resolving and communication system is possible, however the camera thing basically needs something like the real client or the pseuwow client. still these are just simple patches and I'm still just starting to learn C++, but I might look into it in the future.

Ye what I said is incorrect, I just started getting into ace and locks etc and implemented a generic lock today.

Hmm it seems there's some problem with the threading code, but it's not mangchat related.

Apperently I'm doing something wrong or mangos uses a different way of creating a thread, could someone give me an example ?

Regards, Xeross

I was kind of hoping that someone knew this, Only thing I can think of is making this run in a seperate thread and make it sleep for a second or 5 but that is too hacky I think.

Mangos needs to be updated to read/write locks anyways instead of generic locks.

We'll see, Zor helped me and Balrok will help me out tomorrow.

Hey Folks,

I've implemented mangchat into my core recently and noticed the .online command (To list all online players) crashes the server, me and Zor have been trying to fix this for 6 hours now and we're both out of ideas what the problem could be.

The git repository: http://github.com/xeross/mangos

The full backtrace of all threads: http://lecowow.com/gdb.txt

Things tried so far:

• * Adding guards to the source (As you can see in last commit).
  * Removed Intel Memory allocator.
  

Hope someone on here can help me fix this crash,

Thank you for your time, Xeross

I've been working on improving mangchat and recently tried to implement checking if the player is already in the autojoin channel. However the invite and check are executed before the player has joined any channels.

Currently I've added the autojoin function call to the bottom of "WorldSession::HandlePlayerLogin". and my autojoin code is as follows.

// this function should be called on player login WorldSession::HandlePlayerLogin
void IRCClient::AutoJoinChannel(Player *plr)
{
   if(ChannelMgr* cMgr = channelMgr(plr->GetTeam()))
   {
    if(Channel *chn = cMgr->GetChannel(sIRC.ajchan,plr))
	    return;
   }

   // this will work if at least 1 player is logged in regrdless if he is on the channel or not
   // the first person that login empty server is the one with bad luck and wont be invited, 
   // if at least 1 player is online the player will be invited to the chanel

   std::string m_name = sIRC.ajchan;
   WorldPacket data;
   data.Initialize(SMSG_CHANNEL_NOTIFY, 1+m_name.size()+1);
   data << uint8(CHAT_INVITE_NOTICE);
   data << m_name.c_str();

   HashMapHolder<Player>::MapType& m = ObjectAccessor::Instance().GetPlayers();
   for(HashMapHolder<Player>::MapType::iterator itr = m.begin(); itr != m.end(); ++itr)
   {
       if (itr->second && itr->second->GetSession()->GetPlayer() && itr->second->GetSession()->GetPlayer()->IsInWorld())
       {
           data << uint64(itr->second->GetGUID());
           break;
       }
   }
   plr->GetSession()->SendPacket(&data);
}

So the check should work but it seems it gets executed before a player joins the channels like Local etc.

So does anyone know how to fix this help is very much appreciated and once it's working these changes will be released to the public.

Thank you for your time, Xeross

It's in main repo now ^^

Is impossible, lock or delete topic please.

Hey Folks,

I'm in the process of modifying mangchat (Will release a patch once done), 1 thing I dislike is everyone gets a prompt if they want tot join channel X if you enable the autojoin. I was wondering it it's possible to make people automatically join a channel without a prompt or anything.

Current code for making em join is.

void IRCClient::AutoJoinChannel(Player *plr)
{
   //this will work if at least 1 player is logged in regrdless if he is on the channel or not
   // the first person that login empty server is the one with bad luck and wont be invited, 
   // if at least 1 player is online the player will be inited to the chanel

   std::string m_name = sIRC.ajchan;
   WorldPacket data;
   data.Initialize(SMSG_CHANNEL_NOTIFY, 1+m_name.size()+1);
   data << uint8(CHAT_INVITE_NOTICE);
   data << m_name.c_str();

   HashMapHolder<Player>::MapType& m = ObjectAccessor::Instance().GetPlayers();
   for(HashMapHolder<Player>::MapType::iterator itr = m.begin(); itr != m.end(); ++itr)
   {
       if (itr->second && itr->second->GetSession()->GetPlayer() && itr->second->GetSession()->GetPlayer()->IsInWorld())
       {
           data << uint64(itr->second->GetGUID());
           break;
       }
   }
   plr->GetSession()->SendPacket(&data);
}

Thanks for your time, Xeross

Well I encountered an error again I've moved the mangchat stuff into a seperate makefile and library, but forgot to link it, should be fixed now. compiling again.

I fixed it, if an admin reads this lock pleas.

Think I found it I have split the mangchat files from the game Makefile.am and gave em their own. and added

## Additional files to include when running 'make dist'
#  Precompiled Headers for WIN
EXTRA_DIST = \\
   IRCConf.h

Hey,

I am working on implementing mangchat on my test server.

However after compiling, testing on windows, and pushing to my remote git repo I encountered an error. on linux the config didn't load, I further analyzed it and came to the conclusion I needed to edit the IRCConf.h.in file, however after that change being made when I compile I get the error IRCConf.h not found.

So what do I need to do so my IRCConf.h.in gets parsed, SystemConfig.h.in does get parsed and saved to SystemConfig.h so what do I need to do so that it happens with IRCConf.h.in too ?

Thank you for your time, Xeross

I'm using the OpenMP patch, but guess that's something different.

I solved it by resetting one branch to the revision I wanted and mergin that into the current branch. I'm getting quite proficient with git now, merged around 7 branches into 1 right now so pretty cool. am also converting all my SVN repos to GIT.

Depends if they're the same username, but it uses a different object for the ScriptDev database.

Yep that's working as intended it checks for both GM and item.

MailStationery mailType = (pl->isGameMaster() && pl->HasItemCount(18154, 1, false)) ? MAIL_STATIONERY_GM : MAIL_STATIONERY_NORMAL;

As you can see pl->isGameMaster() and pl->hasItemCount() are both checked, I could make it only check for GM level and item so you don't need .gm on if you want.

Well these seem more offlike to me then using the commands, and they can send bigger mails. hope the item one works too.

I suggest you have a look at the talent learning code (Dunno where you can find it though) and then just search for the part that takes away talent points and gives people talent auras and then comment that out, possibly returning an error instead (like not enough talentpoints).

Looks to me like a patch that combines ahbot and the nameannounce command. try to revert your source back to the revision that it's made for, apply the patch, and then merge the newest source into it.

Good to know it's working, haven't tested it myself yet ^^

I have it working on 8587

Going to push it to my linux server now.

hmm someone could use git pull NAME/master to automerge I guess