XTZGZoReX

Hi, I would recommend using std::vector instead of explicit arrays.

It could be in the same repo and still be licensed under the MIT License. It only matters if we linked this program directly into MaNGOS.

Pushed the source. Ready to push the binaries if that's OK.

I vote for static binary patching. Less possible Win32 bugs to deal with for Wine users.

Well, it's about time we start discussing it, and how MaNGOS will handle it both practically and legally. We won't get around patching in one way or another. We generally have two approaches: * Use a loader that injects a DLL into WoW which then patches the memory. * Patch the executable on disk. Personally, I prefer the latter. It's easier. I wrote this tool a few months ago: https://github.com/Trinity-Encore/Encore/blob/master/Trinity.Encore.Patcher/ClientPatcher.cs It uses pattern scanning to find offsets in the executable to patch, so it works for virtually any 4.x executable.

Here's one for 1.12.1.5875 with a few functions marked. http://filebeam.com/3052d71fb6532918173e38519c300c6e

Yeah, I'm sure that's it. I'm definitely running a public server. I'm definitely in this for the money! Wait...... ... MaNGOS is a development project. If you want "stable" versions, use the damn milestones. A source code repository IS MEANT TO HAVE UNSTABLE CODE; THIS IS WHY IT IS NOT MARKED AS RELEASE-STABLE. If development code was not in the source code repository, then WHERE THE HELL ELSE would it be? Do you think code just magically appears out of nowhere?!

That function is not called, ever, anyway, But, the packet structure you posted is correct.

This patch is currently on hold... Besides, it won't work with the current master at all. I plan to incorporate some of the changes in the patch periodically, and then -- eventually -- implement the TerrainMgr.

In [9905]. Thank you .

Why increase...?

In [9807]. Thank you .

Grid coordinates are never supposed to be "outside" grids in the first place. By checking for it, like this, you're just hiding a crash. You should rather assert it, and attempt to find the source of the problem.

Did you ever look at MapManager::Update()? Also, on retail, the same transport has a different GUID on two different maps - i.e. boat in Booty Bay.

Yes, I was notified of those errors a while ago... And for the life of me, I just can't figure out why GCC won't compile it...