terakoth

Delete this post thanks

Hey I have to agree if there is one problem that must be fixed and because it is annoying this bug would take the cake lol.

Here are some ideas that I think would improve Playerbot's existing features:

1) The Playerbot threat system keeps Unit pointers without cleaning them up when combat ends. The player class also keeps unit pointers but when combat ends disposes of them. This could lead to dereferencing deleted memory. To fix this we should either not store pointers (can always store GUID's instead) or clean up the pointers by latching on to the end combat routines in Player.cpp or capturing the outgoing packet to bots called END_COMBAT or something.

2) After killing something, the bots do not go back into auto follow mode. Instead they stall for 6 seconds or so and then loot. This doesn't work when I'm killing lots of mobs all over the place and the bots just sit there.

3) The bots follow way to close together. I liked it better when they followed at larger random distances behind the master. It is hard to select them when they are all on top of each other.

4) The current loot implementation doesn't work for looting world objects such as the early alliance quests to pick grapes for Milly. The problem is I don't see how our bots can know about the world object guid to loot without the master somehow communicating it. We can either make it so when the master loots something and doesn't take the loot, the bots then try to take the quest loot, or once the master loots a quest item, all bots get a copy of the item if they have the quest. I'd prefer the last one because there are only so many grapes I want to pick.

5) There is also this error: 2009-06-18 17:56:57 ERROR:BuildPlayerRepop: player Mshengli already has a corpse

We should probably let the server make the corpse as it would normally for non bots. Actually I think the server is trying to make the corpse, but since Playerbot already made one an assertion fails and the server crashes.

Anyone else have a list of how existing features in Playerbots could be improved? Maybe we can make a stable branch or at least tag a revision that is known to be stable.

I agree it will be a LOT better when the bots come back on time and not delay to pick up loot then return to main path holder. Not to say when the delay happens and ur fighting more than 1 npc creature at once it takes them a little time to notice what is going on lol.

Yes this is a major problem and mangos is for sure not blizzlike when it comes to this but I don't think I would count on this ever because mangos will most likely never see this kind of update, that and a lack of knowledge doesn't help