Jump to content

315907111

Members
  • Posts

    18
  • Joined

  • Last visited

    Never
  • Donations

    0.00 GBP 

Posts posted by 315907111

  1. Shouldn't it be better to fix isHonorOrXPTarget to avoid possible similar crashes from other pieces of code in the future? Something like this should suffice:

    bool Player::isHonorOrXPTarget(Unit* pVictim)

    {

    + if (!pVictim)

    + return false;

    +

    uint8 v_level = pVictim->getLevel();

    This way you don't have to always check pVictim *before* calling the function, which can be troublesome.

    This is minor, but anyway.. :)

  2. //Check camp

    + Player *player = m_session->GetPlayer();

    + if(player->GetTeam() != sObjectMgr.GetPlayerTeamByGUID(guid))

    + {

    + PSendSysMessage("You have add PlayerBot in the different side!");

    + return true;

    + }

    if (mgr->GetPlayerBot(guid))

    {

    PSendSysMessage("Bot already exists in world.");

    SetSentErrorMessage(true);

    Honor points to prevent the brush

  3. they will avoid script/code solutions to problems when they can easily be put in the database, and I have yet to see an example of this that happens on official servers that could not be done easily in a loot template with a handler.

    Agrees with this approach,Impossible to achieve one to add a script, hope the script is more appropriate database management

  4. So the best way to do it is implementing new script event OnItemDestroy? I think it's good idea, but would it be better to call every time when any item destroys, or only if it have assigned ScriptName?

    +: better way than mine, maybe safer, maybe more universal

    -: won't be reloadable, more complicated (needs to be scripted in C++ than only insert record to database ), won't check for item existing, has duration and so on..

    look forward to this patch... ...

  5. Tell me the best way to do it and i will do it :D

    My suggestion is adding new column to item_template table, which refers to loot record in reference_loot_template and after duration expires, the new item will be generated by this loot_template.

    Is not a good idea, at present such a design on the good, that is just a matter of more items

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use