Ambal

Happy New Year to everyone, guys! I wish all of you the very best things the life can offer!

Such issue usually caused by access to already deleted object (in your case it is item).

As far as I understand this issue is not caused be recent [11360]. Am I wrong, Schmoozerd?

In [11367]. Cheers

what is the problem with current Creature::CanInitiateAttack() function?

In [11366]. Thanks

In [11365]. Thank you

Seems like correct solution to this issue.

Very nice, Neo2003. I have no objections about latest patch

Moreover you pass a 50ms diff here every 50ms and same in worldsession so the diff in map is double speed

Why would map update be twice as fast? If you are right then why periodic auras do not expire with double speed? Current packet processing system does not care about MapManager update timer - it simply does not need any of those. Also, if you are aware, some packets are currently executed in Map::Update() function.

So I'd like to get an example of the code which proves your findings - at current stage I do not believe in problems of such sort.

Neo, isn't is easier to remove this code from MapManager::Update(uint32) function:

    i_timer.Update(diff);
   if( !i_timer.Passed() )
       return;

plus setup correct value for WUPDATE_OBJECTS timer to not invent brute hacks with Update(0)? Also, what do you mean by 'set interval = 1000 and get diff = 50'? We always send to Map::Update()/Transport::Update() methods real diffs between updates. So I'm not quite sure what are you trying to fix

P.S. MapManager uses its own timer to handle Map updates, which is different from World tick update timer.

Any info regarding this freeze? Is it actually fixed?

Any news about this patch so far?

Ok, then don't forget to write your feedback once you'll be able to test this commit. Cheers

Janu, are you sure this freeze has gone away? I have no possibility to check, thats why I ask

Well, how many of you are actually host 'private' servers with 2k+ players? Latest mangos core with mtmaps patch is able to host 3.0-3.5k+ online or ~2k in single-threaded mode. We do not have time to create 'cool' things which will make sense for 1% of servers... And mangos is still officially is not multi-threaded.

If you mean 'multi-processing' e.g. several processes hosting one realm - no, mangos is not capable of such things.

In [11284]. Next stop is support for SELECT queries Thanks to everyone involved!

I suggest everyone interested to start testing the latest version of the patch since currently no problems were found on 1k+ realms. In case no issues will be reported I'll commit this patch in nearest week.

Cheers

The most important thing: backup your database! So in case something will go wrong you can easily restore your data.

Please, repost this bugreport in AuctionBot topic. Closed.

yes, please, drop VLD. In case we will need memory leak detector there are plenty brilliant profilers around.

New version of the patch which will properly use static local variables to hold prepared statement related data. Support for rev [11265].

CRITICAL: please, update to the latest patch version due to found critical issues with function static variable initialization in multi-threaded environment! And report by how much your server CPU usage has increased (shouldn't be more than 5-6%).

this might be related to commit [11222]. Can you rollback and check?