Anti

You need to understand this is mango forum & here we have to develope mango, not other emu.

You are wrong, spell should deal a critical hit if target under effect of Flame shock

oh, sry. i didn't seen

return true;

in that way your fix is correct

If you know C++ you can do all what you want. I think it was some kind of mod.

Nice idea, but bad code style.

U can get it from repo by using git.

Use next commands:

8812-8797=15

You need to create a new branch and reset it to needed rev.

git checkout master
git reset HEAD~15

I think here is more right way, cauze we don't need here case for shamy.

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 166cbaa..cc4e581 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -8685,19 +8685,6 @@ bool Unit::isSpellCrit(Unit *pVictim, SpellEntry const *spellProto, SpellSchoolM
                                return true;
                        }
                        break;
-                    case SPELLFAMILY_SHAMAN:
-                        // Lava Burst
-                        if (spellProto->SpellFamilyFlags & UI64LIT(0x0000100000000000))
-                        {
-                            if (Aura *flameShock = pVictim->GetAura(SPELL_AURA_PERIODIC_DAMAGE, SPELLFAMILY_SHAMAN, UI64LIT(0x0000000010000000), 0, GetGUID()))
-                            {
-                                // Consume shock aura if not have Glyph of Flame Shock
-                                if (!GetAura(55447, 0))
-                                    pVictim->RemoveAurasByCasterSpell(flameShock->GetId(), GetGUID());
-                                return true;
-                            }
-                        }
-                        break;
                }
            }
            break;