ApoC

Aplied in [8635]

Thank You.

Applied in [8632].

Thank You.

Try compile withou PCH.

Any testing progress?

What bug does the patch fix? What features does the patch add?

This patch splits up guid->object looking from ObjectAccessor into Maps. This can avoid locking in further MT map updates, speedup lookups because of smaller data set what needs to be looked up through and opens possibilities for simplify another core parts.

For which repository revision was the patch created?

8574

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

None

Who has been writing this patch? Please include either forum user names or email addresses.

ApoC (me)

Patch on pastebin: http://www.pastebin.ca/1586778

Patch on filebeam: http://filebeam.com/9f04e9be290135d35473c7b0024b9f61

Patch on github: git pull git://github.com/apoc/mangos.git per_map_guid_store

Please test the patch and report any crashes/malfunctions. Thanks.

Patch applied with little changes in [8477]

Thank You.

Applied in [8470]

Thank You

Players regenerate correctly but pets seems to stop getting mana eg. Warlock's Imp.

R.

Thanks for testing, fix should be already pushed in my branch

Hi, I looked to this patch and made some changes. Biggest one is coding style clenup but I also improved/renamed some methods and fixed few typos. You can track my progress on:

Github: git://github.com/apoc/mangos.git damagebonus

Applied in [8465]

Thank You.

I did some more changes, fixed few things.

Reverted some of my prev. changes:

* Precise diff for spell casting regen is now 500ms

* Regeneration is done after standart 2s

* Fixed wrong HP regeneration in combat in Spell::CheckPower

* Fixed timer was not reseted after regen in Spell::CheckPower

-----

* Removed dependency on getMSTime() for last mana use effect

Whole patch is on my

github: git pull git://github.com/apoc/mangos.git regen_fix

Can anybody retest?

Applied in [8463]

Thank You.

I found the problem in calculation when for low levels there is no health regeneration. I'll try to fix it ASAP.

I looked at the patch and did few changes:

* Kicked out dependency on GetMSTime() in regen code

* Added some defines instead of magic values

* Cleanup

I would be very happy if some body can test and report possible regressions agains original patch. I tested it little bit with rogue nad priest and looks ok.

Patch on Pastebin: http://www.pastebin.ca/1543415

Patch on filebeam: http://filebeam.com/800169cae9d3a1efe73d5833930a539e (gzipped patch file)

Patch on github: git pull git://github.com/apoc/mangos.git regen_fix

My changes on patch you can see here: http://alturl.com/p68f

I started reviewing patch.

Thanks for topic move, I completely forgotten to it

What bug does the patch fix? What features does the patch add?

* Introduced new table character_battleground_data

* Entry point is now stored on BG enter event not join event

* Entry point for dungeons is now correctly set to nearest graveyard

(this prevent well known assert in GetInstance because of porting to already destroyed instance)

* Teleporting from BG correctly restore mount state

* Teleporting from BG correctly restore taxi flight

(in multipath flight you will end up in nearest transition point on the route)

For which repository revision was the patch created?

[8277]

Is there a thread in the bug report section or at lighthouse?

Don't know any

Who has been writing this patch?

ApoC

I am putting this patch here for wider testing before commit. I am going to 4 day vacation so if commited now I will not be able to react fast for possible troubles so I think this way is better

Patch on pastebin: http://www.pastebin.ca/1511529

Patch on filebeam(gziped): http://filebeam.com/a9a8566142269abb38f9eaeee465f0ec

Patch on github: git://github.com/apoc/mangos.git branch bg_entry_point

(git pull git://github.com/apoc/mangos.git bg_entry_point inside your repo.)

Comments/problem/bugs report below. Feel free to attach patches

Applied in [8260]

Thank You

Applied in [8113]

Thank You.

I had that before but it suffers from two major problems:

[HIGHLIGHT=SQL]

@count := 1;

UPDATE tabelle

SET nummer = @count := @count + 1

WHERE type = "foo"

ORDER BY nummer;

[/HIGHLIGHT]

It can't deal with duplicate key entries, so it just breaks there and it is also a two statement query (initializing the variable) and i don't think mangos can deal with that.

**edit

v2: http://pastebin.com/f8c42714

This should keep code compatibly with postgres.

I think primary key has to be dropped before renumbering.

Please when you are fixing this. Can you make queries PGSQL compatible? So no JOINING in UPDATE queries.

Applied in [8052]

Thank You.

Applied in [8051]

Thank You.

Applied in [8050]

Thank You.

Patch applied in [8049] with checking caster for NULL.

Thank You.