bizkut

MangChat 1.7.9 merged into Mangos 9191. Now with GM ticket function for list/read/respond/delete tickets. respond function doesn't work properly btw. Please help me to correct the code. You can see the changelog here http://github.com/3raZar3/MangChat/commit/dfbb2bf3fd830ea744eb04d9a06084116067146b

Change majorly at the bottom of src/game/mangchat/IRCCmde.cpp and I fix the indentation a lot. Please report/suggest any bug. Thanks

p/s Anybody know how to change indentation in VC2008 express to use spacebar instead of tab spacing?

hmm I see what you did, you moved the code around a little.. will that really affect the overall?

Not at all. Here is the diff between original Player.h and playerbot patch

55a56,59
> // Playerbot mod
> class PlayerbotAI;
> class PlayerbotMgr;
> 
2338a2343,2352
>  
>         // Playerbot mod:
>         // A Player can either have a playerbotMgr (to manage its bots), or have playerbotAI (if it is a bot), or
>         // neither. Code that enables bots must create the playerbotMgr and set it using SetPlayerbotMgr.
>         void SetPlayerbotAI(PlayerbotAI* ai) { assert(!m_playerbotAI && !m_playerbotMgr); m_playerbotAI=ai; }
>         PlayerbotAI* GetPlayerbotAI() { return m_playerbotAI; }
>         void SetPlayerbotMgr(PlayerbotMgr* mgr) { assert(!m_playerbotAI && !m_playerbotMgr); m_playerbotMgr=mgr; }
>         PlayerbotMgr* GetPlayerbotMgr() { return m_playerbotMgr; }
>         void SetBotDeathTimer() { m_deathTimer = 0; }
> 
2598a2613,2616
>          // Playerbot mod:
>         PlayerbotAI* m_playerbotAI;
>     PlayerbotMgr* m_playerbotMgr;
> 

If you could see the code clearly here http://github.com/bizkut/Valhalla-Project/blob/d7afa37d1081827fa88f38a40e5145d9dc0d9301/src/game/Player.h

you need to patch the file manually. I think I did hack-patched it.it compiles fine but I didn't test in game.

Thank you. I just merged mangchat with mangos 9183 there.

btw erazare, do you like to keep mangos patchable against both mangos core and Valhalla or mangos only? I use Valhalla+mangchat on my server, but still patching mangchat against mangos core to keep it clean.

I am working on tickets read/reply/delete. will push to the repo once finished and tested

This patch which will be cleanly applied to mangos 9183 http://pastebin.ca/1752418

blueboy please check the patch if it got any error.

my commit for playerbot is here http://github.com/bizkut/mangos/commit/c9448600a023ffd0191dcf15e7cd07085fc4be9a

with "playerbot" branch

you know when i was looking for help in Shinzon's wiki (yeah i was desperate) i saw something in there about the ticket thing already implemented but it might take some digging through the wiki to find the commands.

there is no command for tickets. only tickets creation/delete announcement was implemented. You can see all commands here src/game/mangchat/IRCCmd.cpp

Don't quit on mangchat. I already move back from mangos->trinity->mangos because of a lot changes on core codes for trinichat and I can't follow it anymore. I can't live without mangchat.lol..I wish tickets management (view/reply/delete) will be added to mangchat soon.

Thank you but it's only a small fix btw

lol i don't know if the repo is good or even compiles but I had push the fix there

I am using git version 1.6.5.1.1367.gcd48 I apply using patch -p1 < mangchat.patch and git add . afterward. My nick at github is bizkut btw. you can add me and I will push the fix.

idk... are you on a windows machine or linux? I am running windows and err... try as i might, this patch just refuses at line 92... i deleted the sql files in the 330 dir and it still fails

I am on windows 7. I patch it against clean mangos repo 9178 and works fine here.

Try using patch -p1 < mangchat.patch instead. Line 92 as we can see is an sql file so make sure 1_account_data.sql is not exists in sql folder

rebase your repo into mangos 9178

git apply mangchat.patch

git commit into your repo

Your existing mangchat repo already messed up. You need to rebase and apply the patch I made, and I think you need to review it first because I am not a good coder.

I mean you need to apply the patch against vanilla mangos 9178. I made the patch from your repo, not Xeross's. sorry for misunderstanding.

I just pulled your mangchat repo into mangos 9178 and see the git diff. I filtered out a few redefined declarations and few unnecessary diff. I don't know much c++ but I wish I can learn from this. Few defines bothered my such as

/src/game/AccountMgr.h

-#ifndef _ACCMGR_H
-#define _ACCMGR_H
+#ifndef _sAccountMgr_H
+#define _sAccountMgr_H

It just look suspicious. I just left as it is. I don't even know what it means lol.

I tested the patch works fine so far. entering/leaving channel announcement works, chat irc<->world works, levelup works. but the level prefix for characters doesn't work and I think it's an old bug. I am always getting [bugTracker] which is for level 3 gm even I am a level 5 gm which supposed to get [sysOP] prefix.

The patch will fix your mangchat repo.

I refined this patch and successfully ran it against mangos rev 9178. http://pastebin.com/f4f44efc3

The thing I'd changed are

 std::string pinfo2 = "\\x2 Race:\\x2\\x3\\x31\\x30 " + (std::string)prace->name[sWorld.GetDefaultDbcLocale()] + "\\xF |\\x2 Class:\\x2\\x3\\x31\\x30 " + (std::string)pclass->name[sWorld.GetDefaultDbcLocale()] + "\\xF |\\x2 Level:\\x2\\x3\\x31\\x30 " + plevel + "\\xF |\\x2 Money:\\x2 " + tempgold + "\\xF |\\x2 Guild Info:\\x2\\x3\\x31\\x30 "+guildinfo+"\\xF |\\x2 Status:\\x2 " + ponline;

to

 std::string pinfo2 = "\\x2 Race:\\x2\\x3\\x31\\x30 " + praceid + "\\xF |\\x2 Class:\\x2\\x3\\x31\\x30 " + pclassid+ "\\xF |\\x2 Level:\\x2\\x3\\x31\\x30 " + plevel + "\\xF |\\x2 Money:\\x2 " + tempgold + "\\xF |\\x2 Guild Info:\\x2\\x3\\x31\\x30 "+guildinfo+"\\xF |\\x2 Status:\\x2 " + ponline;

to make it compile and work correctly. Please someone fix the variables.

there *is* a repo of MangChat for 3.30 [9171] on my git... however it may still be a bit buggylet me know if it gives you any trouble

You redefined twice

src\\game\\ObjectMgr.h(932) : error C2086: 'QuestPOIMap ObjectMgr::mQuestPOIMap' : redefinition

and

..\\..\\src\\game\\Group.cpp(901) : error C2039: 'totalDisenchant' : is not a member of 'Roll'

and

..\\..\\src\\game\\ChatHandler.cpp(71) : error C2065: 'MAX_CHAT_MSG_TYPE' : undeclared identifier

redefined more

..\\..\\src\\game\\CharacterHandler.cpp(53) : error C2011: 'CinematicsSkipMode' : 'enum' type redefinition

that's all the compile error.

First off, this is about playerbot, not some other custom branch, please ask these questions in an appropriate thread or create a clean one.

I am using playerbot which is included in erazare repo and for your information, I was talking about the playerbot's merging from blueboy which may coz the problem.

erazare, I just did git diff between your repo and Valhalla/vanilla mangos/blueboy and I found this

-    //char*       name[16];                                 // 5-20 unused
+    char*       name[16];                                   // 5-20 unused

I commented back the variable and now I can create the character again. I don't certain about this fix but it may give some idea.

I rebuild the server with clean Tiamat db (from MU link) and update it with mangos core patch but still getting the bug. I ran Valhalla latest rev 1971 against the db and I have no problem with character's creation. I believe your repo just get messed up.

for those of you that are interested in the blueboy repo merged with mangchat, vehicles, ahbot, and mangos 9170 fully functional at the best of what all included mods have to offer... make sure to hit my repo's master branch

I can't create a new Gnome rogue character with error "Creation of that class requires an account that has been upgraded to the appropriate expansion". I am aware of realmd db with table expansion "2" and this error only occurs with your 9170 rev. your last rev 9141 works fine.

Nice merge to 9147, erazare. nice work.thanks

erazare, I am one of your loyal git puller. So I like to see your mangchat git for 3.3.0 soon. I LOVE mangchat and I can't live without it

I got this error with the latest branch

g++ -DHAVE_CONFIG_H -I. -I../../../src/game -I../..  -I/usr/include/mysql -I../../../dep/ACE_wrappers -I../../dep/ACE_wrappers  -I../../src/shared -I../../../src/game -I../../../src/game/../../dep/include -I../../../src/game/../framework -I../../../src/game/../shared -I../../../src/game/../shared/vmap -I../../../src/game/../realmd -DSYSCONFDIR=\\"/opt/mangos/etc/\\"   -DENABLE_RA -DENABLE_CLI -DDO_MYSQL -g -O2 -MT Unit.o -MD -MP -MF .deps/Unit.Tpo -c -o Unit.o ../../../src/game/Unit.cpp
In file included from ../../../src/game/Unit.cpp:37:
../../../src/game/Formulas.h:35: warning: ‘typedef’ was ignored in this declaration
../../../src/game/Unit.cpp: In member function ‘uint32 Unit::DealDamage(Unit*, uint32, const CleanDamage*, DamageEffectType, SpellSchoolMask, const SpellEntry*, bool)’:
../../../src/game/Unit.cpp:719: error: ‘player’ was not declared in this scope
../../../src/game/Unit.cpp:739: error: ‘player’ was not declared in this scope
../../../src/game/Unit.cpp:807: error: ‘player’ was not declared in this scope
../../../src/game/Unit.cpp: At global scope:
../../../src/game/Unit.cpp:815: error: expected unqualified-id before ‘else’
make[3]: *** [unit.o] Error 1
make[3]: Leaving directory `/home/bizkut/simple_jail/objdir/src/game'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/bizkut/simple_jail/objdir/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/bizkut/simple_jail/objdir'
make: *** [all] Error 2