ckegg

I just study codes again and I see a lot of security issues, like, bot is not checking if it is in the same map with master in Updated() and "attack" command and others. Making a delay of teleporting without a check won't fix crashes. It is making the same problem while creating a corpse of bot. I believe, PlayerBotAI really need to rewrite.

@Gimp and @tip_1 your two questions I already stated just few post above you....... #243, take a look

You can ignore those errors in conf file because you can just let it run as default value, or just patch manually by yourself, they shouldn't be hard...... (but you have to patch AHbot first because its configuration is more significant than PlayerbotAI) About stability, well, the recently changes from mangos is killing the project. The crash problem from zone changing never get fixed. Unless you put a bot master map check to prevent bots do anything before it get teleport to master's location, it will crash when bot is in different zone/map.

He meant the change of [8302], which dropped the usage of Player::MinimalLoadFromDB

Hmmm I feel so bad When I enable Buyer only, it is buying player's stuff (while AH is clean) but if I enable Seller with Buyer, buyer is not working..... buying nothing, leave it for a day, nothing......

I am using git://github.com/playerbot/mangos.git repository and I pulled the version after you changed player.cpp with relocated p_time check I did many tests too, and all went good. However, I tested a specific one which is entering a instance and leaving a bot outside the instance, or before the bot get in, attack a mob, then it crashes. If I have time in these day, I would investigate the problem

- oops double posts -

This does not help. After you switch map, and if you enter combat without bot presents, server crashes. Map* WorldObject::GetMap() const: Assertion `"m_currMap" &&0' failed.

The formula is in the class GetAuctionDeposit() in AuctionHouseMgr.cpp Actually the deposit percentage is from DBC, (struct AuctionHouseEntry in DBCStructure.h) I think it is a bug of Paradox's version while selecting AuctioneerGUID (ally/horde/neutral) and your version has it fixed (break; ), which affects the deposit value. As result,Paradox's version is buggy and your version is bug free! However, I still can't get Buyer working....... it is not bidding or buying anything still. and while changing Rate.Auction.Deposit in conf, the display deposit value is incorrect in game, but after putting the item in auction, it charges with the defined rate. I believe it is core's bug. ------- EDIT --------- I found the reason why Buyer is not working: search for this line in AuctionHouseBot.cpp for (uint32 count = 1;count < config->GetBidsPerInterval();++count) You should not start the count from 1 because the default value is 1 in configuration, so it will never get in the loop. In order to get the Buyer working, you have to either set buyerBidsPerInterval greater than 2 in configuration (but some people just want one items at the time) or fix this statement. for (uint32 count = [b]0[/b];count < config->GetBidsPerInterval();++count) or for (uint32 count = 1;count [b]<=[/b] config->GetBidsPerInterval();++count) hope this help.

Actually it happens on any map changing, like entering a instance, switching map while taking boats, etc I am using x64 unix system....

I have a question..... How come when I use the original Paradox version (or GigElf's one), deposit amount is following the formulas (http://www.wowwiki.com/Formulas:Auction_House#Deposits) but when I use Naicisum's version, the deposit is the same as the starting price (vendor price)...... which is not following the formulas?? I think you have some problem storing the value of item's vendor price, which causes deposit's amount is incorrect and buying problem.

Got a report that when people do heartstone from azeroth back to outland will crash the server Don't have crash log atm......

Updating to 8222 this problem is gone.

You just don't dig this thread and post like this?

We know that currently Mount is store in pet slot as spell for character If we do GetSpellMap(), yes, we can find the mount stored in the spell map. However, is there a way to determine the spell is "mount"? Like a flag says _MOUNT or something similar Or, is there a slot map for mount (in pet panel)?? I look through mangos and can't find such as thing You know, currently mount is not working for BOT for 3.x.x ....

No need to use -fopenmp Just compile and go.

Who did the changes to /contrib/ and /dep/ files? If you are pushing to PlaybotAI branch, please don't push your custom stuffs please It looks really bad, gonna need some clean up

@walkofdoom: Thanks for the report and found that bot is trying to choose item from receiving multiple reward items. I also discovered that auto choose reward is way too simple, bot chooses item from the first available reward or the one has the greatest armor value. I believe we can do something like trading feature, bot will tell you what rewards are available and you just link back the item and it will pick the one you requests. - Fixed a bug that bot is trying to choose item from receiving multiple reward items. - Quest title localization support - Now multiple rewards will also report in tooltips upon quest completion.

I will fix this asap I found the problem thanks for the report ====== update ==================================== - Using standard coding style, makes it more logical and much easier to read. - fixed rogue victim check If you are working on playerbot, please try to avoid using indent (tab, or \\t) and use 4 spaces instead. I know most coding environment will auto indent when you go to next line, but some people may use text editor, which makes code unreadable. (like me, in linux platform) Also, try to use logical style, don't put everything in the same line, ie: if (!m_bot) return; use if (!m_bot) return; and becareful with brackets and if statements if (m_bot) { m_bot->I_WILL_KILL_MYSELF; return true; } else { return false; } make it clear so other people can read easier if (m_bot) { m_bot->I_WILL_KILL_MYSELF; return true; } else return false;

How about this? float angle = m_bot->GetAngle(target->GetPositionX(), target->GetPositionY()); m_bot->MoveChase(target, dist, angle); or m_bot->GetMotionMaster()->MovePoint(0, x ,y, z); // just go while (!m_bot->IsWithinDistInMap(target, dist)) { // then check if is in dist m_bot->GetMotionMaster()->Clear(false); // stop m_bot->GetMotionMaster()->MoveIdle(); // call range / spells here ? } The first one is the correct way to do it, the second one isn't good because it is a loop, but it should work for the finish moves, what about check for UNIT_FLAG_FLEEING and do Cheap Shot, Root, Hamstring or anything related spells?

ok I am going to get one now I never thought that I would use it

Yes, I had them fixed.

I don't think it is a good idea. As I stated in other thread, you have to take care of authorization like providing password of an account to call each bot, it may lead to a major security issue. You also have bot controlling issue if you are using different account bots.

Cheer I am going to work on item locale problem ==== update ===== - Add item localization support

Is there a way to search object in grid without supplying object id? I know there is a similar way used in .gobject target, but it searches in database, not grid and most search method have to provide object id to search in grid. The reason I am asking this is searching object in range and if object type is door (without providing object id), it will get the coordinate of it and check if it is in front of the caster and blink stops in front of the door.