Darkruler

in yours

My commits are the same as Salja's (used the same source, Traponinet and Tasssadar) so the only difference is that i use Insider42's commits :confused:

hope someone can test Insider42's GIT without vehicle patch, can't imagine the vehicles can f*** up DK start zone

there is a crash when some one is creating a death knight, and enters the game at the start zone server crashes!!!

Which repo, mine or Salja's?

Working on it!

Thank You!!!

Updated my Insider42 git

Salja, your vehicle repo causes rogues to not be able to gain combo points.... also i've had reports that warlocks couldnt gain soul shards. could someone please update salja's or the good ol' Tassadar vehicle branch?

somewhere around line 661 of PetHandler.cpp

try changing

-       //recvPacket >> targets.ReadForCaster(pet);
+        recvPacket >> targets.ReadForCaster(pet);

I am using insider's42 repo and some of my changes...

If i will pull salja's repo it's not working...

i will update my Insider42 repo for you

Salja's repo has more features and is updated more frequently...

off-topic:

i don't have much time to update it because:

i'm working on an application that downloads source from a github repo, automatically compiles it and filters all compile errors and puts those in seperate logs (one for SD2, one for the core) and it can also use SVN to receive a database and import it

BUMP, is this proper for implementation in the master branch?

Darkruler did i ever tell you i love you? >.>

no you didn't

not tested this, but atleast it compiles

Aura *aur = GetAura(71905, EFFECT_INDEX_0);
+	if (aur && uint32(aur->GetStackAmount()) == 1)
+		CastSpell(this, 72521, false);       // First Effect
+					
+	if (aur && uint32(aur->GetStackAmount()) == 6)
+	{
+		RemoveAurasDueToSpell(72521);       // remove First Effect
+		CastSpell(this, 72523, false);       // Second Effect
+	}
if (aur && uint32(aur->GetStackAmount() + 1) >= aur->GetSpellProto()->StackAmount)
{
+		RemoveAurasDueToSpell(72523);       // remove Second Effect
	RemoveAurasDueToSpell(71905);       // remove Shards
	CastSpell(this, 71904, true);       // Chaos Bane
	return true;
}

This is the first time i write something for a spell, before this i've only made custom configs for various stuff, so i would appreciate it if someone more experienced can respond on this

Sorry, just woke up so this might be completely bullshit, but seems to me this should work (or atleast partially)

// Item - Shadowmourne Legendary
case 71903:
{
  if (!roll_chance_i(triggerAmount))
     return false;

Aura *aur = GetAura(71905, EFFECT_INDEX_0);
--------------------------------------------------------------------------
if(GetStackAmount()== 1)
  caster->AddAura(72521, caster);

if(GetStackAmount() == 6)
{
     caster->RemoveAura(72521);
     caster->CastSpell(caster, 72523, false);
}
--------------------------------------------------------------------------
if (aur && uint32(aur->GetStackAmount() + 1) >= aur->GetSpellProto()->StackAmount)
{
     caster->RemoveAura(72523);
     RemoveAurasDueToSpell(71905);
     CastSpell(this, 71904, true); // Chaos Bane
     return true;
}

added part is between

--------------------------------------------------------------------------

don't try to use it, i know it's wrong but i need some caffeine before fixing it

yes sry i know but i have 9756 and this dont work for me why?

read the notes by Vlad [9715]

I don't want to be rude... but can anyone translate above post to normal english i don't really get it

i will answer the part i do understand:

- Dual-spec is officially included in MaNGOS as of Rev [9715]

- Vehicles aren't yet as the developers would like to see them.. so it needs some more attention (i don't have time to develop it further though...that's up to Traponinet and Wojta...and ofcourse the other collaborators on the patch)

i do same you type , but i have this error ?

thanks

might be because of my git config

try git checkout-m origin/Insider42

i tray to get Insider42's repo with vehicle patch , but i can't . i use this command

git clone git://github.com/Darkrulerz/mangos.git Insider42

thanks

git clone git://github.com/Darkrulerz/mangos.git

git checkout -m Insider42

you can't select a branch in a clone

going to do a forced push to get the credits straight

~~solved~~

Clean MaNGOS with vehicle patch : http://github.com/Darkrulerz/mangos/commits/master

Insider42's repo with vehicle patch : http://github.com/Darkrulerz/mangos/commits/Insider42

if it doesn't compile or anything, don't hesitate to send me a PM on github

Hopefully, someone will come along and sort this mess into a unified patch and/or Git repository. I've been wanting to try the Vehicles mod, but things are such a confused mish-mash of fixes, updates from several different people, and a very old repo that I've just not had the will to endure sorting through the mess to have a working patch.

Time to call out the janitors.

working on it... will make github branches based on insiders repo and one on plain mangos with vehicles and keep track of comming updates

Will post a link tomorrow

I wasn't talking about simple merge errors, but the whole repo is sofar out of date that the DB changes are not even in there. If it was a simple merge error I wouldn't have commented plus this topic is getting so blasted confused I can't even keep up.

mmh ok.. if someone gives me an updated file (with previous fixes posted here)..i will maintain a GIT and put all posted updates in it

@Darkruler, also Tasssadar's vehicle repo hasn't been updated for quite some time and I can't even get it to apply anymore.

Solving merge conflicts and compile errors is easy...afterwards i pull the additional things for vehicles that somehow aren't in the vehicle branch from the master branch (target types and not use pet AI for example)

traponinet can you make Pls a Full Patch for all new Updates Thanks.

git pull git://github.com/Tasssadar/Valhalla-Project.git vehicle

and apply the 2 patches posted earlier...

no need for a patch file

Look at line 20859 in this file

http://rapidshare.com/files/374320193/Playerbeforeupdate.cpp.html

I apply this patch

http://github.com/cristal/talent/commit/c04b4e1d6ed9848a70da7071790883e615868182

Look the result

http://rapidshare.com/files/374320611/Playerafterupdate.cpp.html

lol, perhaps you can make pics for him?

which repository?

Tasssadar's repo... check the 2nd commit from the top.. that's what tester20 is talking about

i have done it everythign works apart from players seeing each other is this a know bug? im using rev 9720

Fixed in 9724

I meant being free to mount up while inside Dalaran (everywhere)

compile error on core 9582 with your patch

can't be because of his patch.... he removed 2 checks...nothing added...

Updated to rev.6! If you have any suggestions to make this work even better feel free to share them

thank you!

edit: forgot I was the last one to post before this lol sorry about that.

edit: Updated to rev.9

make it so that when this patch is turned off (disabled), Dalaran is a zone where you can freely fly (so disabling results in the exact opposite)