dogeht

anyone else tested this patch?

could this work under rev 9110?

if you could post it with the fix you made i would be really gratefull cause i dont know where to add the check you posted, or you could tell me in what part of the code is it suposed to be.

is it inside

if (spellProto->Effect == SPELL_EFFECT_WEAPON_DAMAGE_NOSCHOOL || spellProto->Effect == SPELL_EFFECT_WEAPON_PERCENT_DAMAGE || spellProto->Effect == SPELL_EFFECT_WEAPON_DAMAGE || spellProto->Effect == SPELL_EFFECT_NORMALIZED_WEAPON_DMG) ???????????

maybe it is after the loop

+    bool hasWeaponDmgEffect = false;
+    for (uint32 i = 0; i < 3; ++i)
+    {
+        if (spellProto->Effect[i] == SPELL_EFFECT_WEAPON_DAMAGE_NOSCHOOL || spellProto->Effect[i] == SPELL_EFFECT_WEAPON_PERCENT_DAMAGE || spellProto->Effect[i] == SPELL_EFFECT_WEAPON_DAMAGE || spellProto->Effect[i] == SPELL_EFFECT_NORMALIZED_WEAPON_DMG)
+        {    
+            hasWeaponDmgEffect = true;
+            break;
+        }
+    }
+// Check if effect can trigger anything actually (is this a right ATTR ?)
+    if( spellProto->AttributesEx3 & SPELL_ATTR_EX3_UNK16 )
+        hasWeaponDmgEffect = false;
+    if (!(damageInfo->HitInfo & HITINFO_MISS) && hasWeaponDmgEffect) 
+    {
+        WeaponAttackType attType = GetWeaponAttackType(spellProto);
+        // on weapon hit casts
+        if(GetTypeId() == TYPEID_PLAYER && pVictim->isAlive())
+            ((Player*)this)->CastItemCombatSpell(pVictim, attType);
+    }

mangos 9036

snakes only shows up if the hunter doesnt have his pet out, and attack they owner

anyone tested it?

I was wondering the same thing

thanks

sorry if im wrong but I think this patch missed the DD spell bonus form Unstable Affliction in this part :confused:

-- ('30108', '0', '0.2', '0', 'Warlock - Unstable Affliction'),

according to http://www.wowwiki.com/Spell_power_coefficient

the DD spell coefficient for unstable affliction is 180%

maybe this should not be covered by default calculation and inserted in the table as

-- ('30108', '1.8', '0.2', '0', 'Warlock - Unstable Affliction'),

if not, at least someone more experienced could look at the DD spell coeficient of UA

sorry about bad english.

Yea the tooltip even says "When the Haunt spell ends or is dispelled, the soul returns to you, ..."

Though i assume, the sooner you dispel it, the less damage it did and the less it will heal. Couldn't test yet if that part is implemented correctly too. It's not clear to me by looking at the commit alone...

haunt is not a DOT , it is a DD spell so if it hits for 4K it should heal for 4K no matter what.

On offy if haunt is removed by dispel, the soul doesn't return to spell's caster, not healing him. (This also affects Shadow Embrace, it is not applied if Haunt was dispelled before aura update on offy)

Any time the debuff is removed you get the heal. It doesn't matter if it times out, you cast another Haunt (on the same or a different target), it's dispelled, or the target dies.

http://www.wowhead.com/?spell=48181#comments

any news? :confused:

mangos 8582 Mixology bug still exist

http://www.wowhead.com/?spell=53042#comments

no bonus from elixirs and flask

hi, i just wanted to add something, while using bladestorm the warrior should still be vulnerable to death coil(terror effect, not fear) , and shamans thunderstorm pushback effect