fullburned

Up. Problem still exists.

Works fine on my test server, had no complaints from users. Hope someone can review it.

@Atømic thx, i've missed that, first post updated with new link. Be sure to put the code under SPELLFAMILY_PALADIN case.

Maybe these sql changes can help. Source: http://code.google.com/p/trinitycore/source/detail?r=2db20d21cc

Huh, wrong dbc data, i guess. I've looked at spells description and suddenly noticed: So these 8 (2 for 2k, 2 for war, 2 for rogue, 2 for manausers; 2 because there's a heroic version of this item) spells should actually proc according to players class. You can find these spells on wowhead, just search Invigoration. Though, I'm not skilled enough to write a patch. And about wowhead... seems that they have correct dbc (or someone provided them with it). Description of spell is just "Server-side script". Ok, I've written a patch, will publish it after testing.

I still get "if (target->processed)" crashes. So the solution with using tbb::concurrent_vector doesn't help.

Doesn't help.

Aw, I have the same bug but I'm not sure if this patch causes this. Will try soon without it=\\ At least I'm not alone:rolleyes:

Bump:) After 2 months of testing no bugs were spotted.

Holly wars FTW! P.S. This thread is about vehicles patch for mangos

I know it's useless but I'll give a try. Have anyone come across efficient way to know vehicle id of some creature? Or maybe it's possible to know the actual visual view of vehicle from vehicle.dbc without sniffing data from off server? Or maybe someone can explain how to properly use .debug spawnvehicle command? That's seems to be one of the main troubles for me now, I have data for 5 quests but without knowing vehicle id for npc it's useless:(

I think that would be useful to you, thats patch for aura 262 that was made 3 months ago:) http://getmangos.org/forum/showpost.php?p=276528&postcount=26 At least you can take changes for sudden death - that would make your patch more complete

You needn't vehicle support to make this spell work... It's based on mindcontrolling summoned creature. But you'll need script support to do it more offlike. You see, the eye of acherus flies to scarlet base without your help, so mostly this feature needs a script. And the last thing, the patch from griffonheart is really outdated and refused to work for me long time ago

@Lightguard Sql query worked for me(for a character that learned it before). Can this be included to git or is it a hack, looks realy confusing

DELETE FROM `creature_template_addon` WHERE `entry` IN (28670, 28312, 32629, 28319, 32627, 28094, 29929, 28782); I think this query should be added to vvv_vehicle_test_data.sql before adding new values to creature_template_addon. The reason for this: if you revert structure changes for `creature_template_addon` and then again try to run vvv_vehicle_test_data.sql, the queries like "INSERT IGNORE INTO creature_template_addon" won't work.

Seems that really vehicle spells aren't working anymore=\\

That's mangos-0.12 problem, only on unix again:) You should remove trailing backslashes... diff --git a/sql/updates/Makefile.am b/sql/updates/Makefile.am index fd7292a..ae9f46f 100644 --- a/sql/updates/Makefile.am +++ b/sql/updates/Makefile.am @@ -91,7 +91,7 @@ pkgdata_DATA = \\ 051_8158_01_mangos_playercreateinfo_action.sql \\ 052_8072_01_characters_characters.sql \\ 052_8072_02_characters_characters.sql \\ - 053_8190_01_mangos_creature_template.sql \\ + 053_8190_01_mangos_creature_template.sql \\ README ## Additional files to include when running 'make dist' @@ -162,5 +162,5 @@ EXTRA_DIST = \\ 051_8158_01_mangos_playercreateinfo_action.sql \\ 052_8072_01_characters_characters.sql \\ 052_8072_02_characters_characters.sql \\ - 053_8190_01_mangos_creature_template.sql \\ + 053_8190_01_mangos_creature_template.sql \\ README outdoor pvp code compiles fine, though.

http://getmangos.ru/forum/showthread.php?t=19053

Oh, and I forgot to mention - it crashes even without that mistake... and with this check too: if(plr && plr->GetBoundInstance(GetId(), GetSpawnMode())) Backtrace is mostly the same...

WIth this patch server crashes every 5min. BT: http://paste2.org/p/198687 The first visible error in the code: "bool instanceHasId" is defined twice

2ChanfF07 You can look in http://www.wowhead.com/?spell=20577 code, maybe it will help you;)

2charlie2025 Please backport last commit to outdoor_0.12 branch, it has the same compile errors=)

Hi, recently I've seen too many spam in logs: The thing is that this is some reward spell for Outdoor pvp in Silithus. But that's not not the main problem... I had reports in the same time that players can farm honor along with this rewards with only mouse clicking. I've just removed this spell along with honor rewards from sources... hope someone can fix this problem properly=\\ That's the buggy piece of code, I'm taling about: http://github.com/charlie2025/mangos/blob/0ef5262b7d61a2db9c8c04d0b69778aaef376a53/src/game/OutdoorPvPSI.cpp

2przemratajczak I got a huge spam too... And at the moment when it happens players report that half of their spells/talents doesn't work. Got mangos 0.12 r7374 mtmaps,procflag,av,outdoor pvp,speehack fix and a few other little patches... The part of code with ProcDamageAndSpellFor is rewrited in mangos 0.13. The only idea that comes to me head - to replace sLog.outError("Prevent possible stack owerflow in Unit::ProcDamageAndSpellFor"); if (procSpell) sLog.outError(" Spell %u", procSpell->Id); with sLog.outDebug("Prevent possible stack owerflow in Unit::ProcDamageAndSpellFor"); if (procSpell) sLog.outDebug(" Spell %u", procSpell->Id); But that's not the best solution=(